Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce machine size for clique/BFT ATs #6392

Merged
merged 3 commits into from Jan 12, 2024
Merged

reduce machine size for clique/BFT ATs #6392

merged 3 commits into from Jan 12, 2024

Conversation

macfarla
Copy link
Contributor

same change as was made in #6384 for permissioning ATs

@macfarla
reduce machine size
516f851 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

fab-10
fab-10 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since still faster than unitTests and referenceTests

@fab-10 fab-10 enabled auto-merge (squash) January 12, 2024 17:02
@fab-10 fab-10 merged commit b65c633 into hyperledger:main Jan 12, 2024
17 checks passed
macfarla added a commit to macfarla/besu that referenced this pull request Jan 15, 2024
@macfarla
revert hyperledger#6392 back to xl machine executor
ab31105 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla mentioned this pull request Jan 15, 2024
Merged
@macfarla macfarla deleted the max-workers-clique-ats branch January 29, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

@fab-10 fab-10 fab-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@macfarla @jframe @fab-10