Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eth_blobBaseFee #6581

Merged
merged 2 commits into from Feb 16, 2024
Merged

feat: add eth_blobBaseFee #6581

merged 2 commits into from Feb 16, 2024

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

Add eth_blobBaseFee

Fixed Issue(s)

fixes #6579

@Gabriel-Trintinalia
feat: add eth_blobBaseFee
244a95a 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited by Gabriel-Trintinalia

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

@Gabriel-Trintinalia Gabriel-Trintinalia added the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 16, 2024
macfarla
macfarla approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine. maybe a changelog entry, and docs-required label

@Gabriel-Trintinalia
add entry to changelog
f0509cc 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit bc2eed1 into hyperledger:main Feb 16, 2024
78 checks passed
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 24, 2024
@Gabriel-Trintinalia @suraneti
feat: add eth_blobBaseFee (hyperledger#6581)
2cf95c6 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@alexandratran alexandratran mentioned this pull request Feb 27, 2024
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement eth_blobBaseFee
3 participants
@Gabriel-Trintinalia @macfarla @alexandratran