Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance tests to use bonsai #6619

Merged
merged 5 commits into from Feb 28, 2024
Merged

Acceptance tests to use bonsai #6619

merged 5 commits into from Feb 28, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 27, 2024 •
edited

fixes #6583

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

@macfarla
acceptance tests use bonsai default
904747f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
use given config else bonsai
5547fb5 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ats-bonsai
7dbe2e2
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ats-bonsai
2540189
@macfarla
use given config or else default bonsai
e1bcd86 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
siladu
siladu approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple 👍

@macfarla macfarla merged commit 647750c into hyperledger:main Feb 28, 2024
60 of 63 checks passed
@macfarla macfarla mentioned this pull request Feb 28, 2024
Closed
jflo added a commit to jflo/besu that referenced this pull request Mar 4, 2024
@jflo
Revert "Acceptance tests to use bonsai (hyperledger#6619)"
94c644f 
This reverts commit 647750c.
jflo added a commit to jflo/besu that referenced this pull request Mar 4, 2024
@jflo
Revert "Acceptance tests to use bonsai (hyperledger#6619)"
ee9f0b1 
This reverts commit 647750c.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla added a commit that referenced this pull request Mar 4, 2024
@RoboCopsGoneSock @jflo @macfarla
Revert "Acceptance tests to use bonsai (#6619)" (#6677)
671e35a 
This reverts commit 647750c.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo added a commit to jflo/besu that referenced this pull request Mar 5, 2024
@RoboCopsGoneSock @jflo @macfarla
Revert "Acceptance tests to use bonsai (hyperledger#6619)" (hyperledg…
412de29 
…er#6677)

This reverts commit 647750c.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo added a commit to jflo/besu that referenced this pull request Mar 8, 2024
@RoboCopsGoneSock @jflo @macfarla
Revert "Acceptance tests to use bonsai (hyperledger#6619)" (hyperledg…
2367538 
…er#6677)

This reverts commit 647750c.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
This was referenced Mar 21, 2024
Closed
Open
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
Acceptance tests to use bonsai (hyperledger#6619)
236f5c9 
* use given config or else default bonsai

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@RoboCopsGoneSock @jflo
@macfarla @amsmota
Revert "Acceptance tests to use bonsai (hyperledger#6619)" (hyperledg…
af25e51 
…er#6677)

This reverts commit 647750c.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
Acceptance tests to use bonsai (hyperledger#6619)
213170b 
* use given config or else default bonsai

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@RoboCopsGoneSock @jflo
@macfarla @amsmota
Revert "Acceptance tests to use bonsai (hyperledger#6619)" (hyperledg…
498b78c 
…er#6677)

This reverts commit 647750c.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change ATs to use Bonsai since this is now the default storage mode
2 participants
@macfarla @siladu