Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap server rebase #6640

Merged
merged 16 commits into from
Mar 30, 2024
Merged

Snap server rebase #6640

merged 16 commits into from
Mar 30, 2024

Commits on Mar 30, 2024

  1. squash of snap server commits 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    0e1b41f View commit details
    Browse the repository at this point in the history

  2. address potentially null storage format that occurrs in some unit tests 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    73567a2 View commit details
    Browse the repository at this point in the history

  3. add snapserver experimental flag, refactor snap server start 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    d3a91aa View commit details
    Browse the repository at this point in the history

  4. add a timeout to prevent snap requests from breach of protocol by tak… 

    …ing more than 5 seconds

Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    0700841 View commit details
    Browse the repository at this point in the history

  5. changelog 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    261a39e View commit details
    Browse the repository at this point in the history

  6. add handling for missing sync config in controller builder for unit t… 

    …ests

Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    0a3a3b0 View commit details
    Browse the repository at this point in the history

  7. fix initial sync listener registration and startup ordering 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    f9976b1 View commit details
    Browse the repository at this point in the history

  8. reuse stopWatch from individual methods in snap predicates and short … 

    …circuit

Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    19f2c71 View commit details
    Browse the repository at this point in the history

  9. some cleanup and change to snap-server cli param to disable messages … 

    …rather than protocol

Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    bd6270e View commit details
    Browse the repository at this point in the history

  10. add predicate to empty account range fallback. add log warning when s… 

    …nap request takes too long

Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    25d81e0 View commit details
    Browse the repository at this point in the history

  11. use a new WorldStateStorageCoordinator with explicit cached storage f… 

    …or proof generation

Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    237f118 View commit details
    Browse the repository at this point in the history

  12. default limit hash to 0xFF..FF if not present in the snap range message. 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    0f74064 View commit details
    Browse the repository at this point in the history

  13. review feedback 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    633ac98 View commit details
    Browse the repository at this point in the history

  14. implement feedback from Karim 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    aa9cc79 View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte @macfarla
    garyschulte and macfarla committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    f66661c View commit details
    Browse the repository at this point in the history

  16. additional feedback from Sally 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
    @garyschulte
    garyschulte committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    270e2cc View commit details
    Browse the repository at this point in the history