Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for removed and added test when splitting by time in CI #6990

Merged
merged 1 commit into from Apr 23, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Apr 23, 2024

PR description

Current splitTestsByTime.sh script fails to detect ATs that are removed and does not add new test, this PR add support for both

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 marked this pull request as ready for review April 23, 2024 20:36
@fab-10 fab-10 force-pushed the split-test-by-time-add-remove-test branch from f82a84d to 14b8eab Compare April 23, 2024 20:38
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the split-test-by-time-add-remove-test branch from 14b8eab to 67e80ce Compare April 23, 2024 20:47
@fab-10 fab-10 enabled auto-merge (squash) April 23, 2024 21:00
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot

@fab-10 fab-10 merged commit e4df70a into hyperledger:main Apr 23, 2024
42 checks passed
@macfarla macfarla mentioned this pull request Apr 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants