Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JUnit test reports on PR merged on main #7141

Merged
merged 1 commit into from
May 27, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented May 24, 2024

PR description

JUnit test reports are used to split acceptance and unit tests by time, but since these reports are only downloaded from main branch, and we do not run tests on main, it is necessary to just copy the reports from the last merge PR to the main branch, as done in this PR.

Note: since this PR is referencing some artifacts that are still not present on main (they will be after this PR is merged), tests are just split in a round robin way as fallback, and some download actions will report error.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the update-test-reports-on-main branch 8 times, most recently from f34a8cb to 717edaf Compare May 27, 2024 12:53
@fab-10 fab-10 marked this pull request as ready for review May 27, 2024 13:15
@fab-10 fab-10 force-pushed the update-test-reports-on-main branch 2 times, most recently from 4bc2ea0 to bdd500e Compare May 27, 2024 13:44
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the update-test-reports-on-main branch from bdd500e to 03aa9dc Compare May 27, 2024 13:59
@macfarla macfarla merged commit 067164f into hyperledger:main May 27, 2024
37 checks passed
jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants