-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Java 21 for build and runtime #7177
Changes from 11 commits
7dc3695
baec0a8
263f8b3
82829b3
44f9b9a
f35eb45
5eef735
a2f2cb2
9279067
194f161
bc3d551
22c62bc
1505585
c355ba4
0a949ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4746,6 +4746,14 @@ | |
<sha256 value="f1c00e59fb8e446f0710bdc1719e61952f27c1614ae478452c2f0011035322ae" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.agent" version="0.8.11"> | ||
<artifact name="org.jacoco.agent-0.8.11.jar"> | ||
<sha256 value="d3ed85dea78a9ed55846a7738e3a0ca15c702c661ee4bc8cbfe02a8b9f4a99c0" origin="Generated by Gradle"/> | ||
</artifact> | ||
<artifact name="org.jacoco.agent-0.8.11.pom"> | ||
<sha256 value="16e05e9f49621b87c53e69350140f3c46d42d966c67a933bdf4b063a2b1c8fc5" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.agent" version="0.8.8"> | ||
<artifact name="org.jacoco.agent-0.8.8.jar"> | ||
<sha256 value="072ecbd496896623899a696fff12c01c1615f737616d2792e6d0e10cdf8a610d" origin="Generated by Gradle"/> | ||
|
@@ -4754,6 +4762,14 @@ | |
<sha256 value="7dd13c80aff315032983357c650a887d6fdb4c8a8870b207bb4802c49809e7b4" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.ant" version="0.8.11"> | ||
<artifact name="org.jacoco.ant-0.8.11.jar"> | ||
<sha256 value="81d7eb8890d9be30a939612c295603541063529cdd03a53265aba74474b70b7c" origin="Generated by Gradle"/> | ||
</artifact> | ||
<artifact name="org.jacoco.ant-0.8.11.pom"> | ||
<sha256 value="7ed103d959d0cee7babfb1307fa6e451b1696ffd3527061553b550de55201d85" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.ant" version="0.8.8"> | ||
<artifact name="org.jacoco.ant-0.8.8.jar"> | ||
<sha256 value="02e33bd2c48dc0be67c2fea84d43beececfd400da6797c58153253d4c30aca15" origin="Generated by Gradle"/> | ||
|
@@ -4762,11 +4778,24 @@ | |
<sha256 value="fafff75819609030f4626509313c0861428c2c26c8d36e9a8938334a04478909" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.build" version="0.8.11"> | ||
<artifact name="org.jacoco.build-0.8.11.pom"> | ||
<sha256 value="5b84b15cf2eef3e59eb91bc22784833100b09df9911e3319030c3bc648bd8b0b" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.build" version="0.8.8"> | ||
<artifact name="org.jacoco.build-0.8.8.pom"> | ||
<sha256 value="f4ce0b1285fd24fc6c772f42857298315904dde8fd5677267a0fad5ff9ce2aef" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.core" version="0.8.11"> | ||
<artifact name="org.jacoco.core-0.8.11.jar"> | ||
<sha256 value="fcd188c688473fc8dcc0c6caaf355e7b389502243527c33b9597a3ec28791f47" origin="Generated by Gradle"/> | ||
</artifact> | ||
<artifact name="org.jacoco.core-0.8.11.pom"> | ||
<sha256 value="bb6135f10a36349cb84a5600fd8cf73fc1296a135b2f14adcd83de8cf24cabb1" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.core" version="0.8.8"> | ||
<artifact name="org.jacoco.core-0.8.8.jar"> | ||
<sha256 value="474c782f809d88924713dfdbf0acb79d330f904be576484803463d0465611643" origin="Generated by Gradle"/> | ||
|
@@ -4775,6 +4804,14 @@ | |
<sha256 value="f5fab5a48df823b83c0ea35026032368cc9b81800efb257cc7a5928298fee225" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.report" version="0.8.11"> | ||
<artifact name="org.jacoco.report-0.8.11.jar"> | ||
<sha256 value="8393295ae24680ed10cad8333907040f928b871332491581ca5bc784e2cb4fbe" origin="Generated by Gradle"/> | ||
</artifact> | ||
<artifact name="org.jacoco.report-0.8.11.pom"> | ||
<sha256 value="8e3b734779d5e3fd683ec015413d52f961984c50cb9045fda2b23bff5eb42381" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.jacoco" name="org.jacoco.report" version="0.8.8"> | ||
<artifact name="org.jacoco.report-0.8.8.jar"> | ||
<sha256 value="2c129110f3e3fcaa1f8179578ea3894586199cb0826be5c7790278084c9622a9" origin="Generated by Gradle"/> | ||
|
@@ -5637,6 +5674,14 @@ | |
<sha256 value="02824e839f2a2f0e72959fdd30b4897240f05afc43de42d7ba0b18437601c070" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.ow2.asm" name="asm-commons" version="9.6"> | ||
<artifact name="asm-commons-9.6.jar"> | ||
<sha256 value="7aefd0d5c0901701c69f7513feda765fb6be33af2ce7aa17c5781fc87657c511" origin="Generated by Gradle"/> | ||
</artifact> | ||
<artifact name="asm-commons-9.6.pom"> | ||
<sha256 value="a98ae4895334baf8ff86bd66516210dbd9a03f1a6e15e47dda82afcf6b53d77c" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.ow2.asm" name="asm-tree" version="9.2"> | ||
<artifact name="asm-tree-9.2.jar"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can the old asm-tree entry be removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. apparently they are still referenced .... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so both versions are being used? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like it, I removed it and gradle started complaining about missing metadata. |
||
<sha256 value="aabf9bd23091a4ebfc109c1f3ee7cf3e4b89f6ba2d3f51c5243f16b3cffae011" origin="Generated by Gradle"/> | ||
|
@@ -5645,6 +5690,14 @@ | |
<sha256 value="f61f3ebea5520ddf19f452b03c426c7231bdd8a81d7ac28765cb5271225ac378" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.ow2.asm" name="asm-tree" version="9.6"> | ||
<artifact name="asm-tree-9.6.jar"> | ||
<sha256 value="c43ecf17b539c777e15da7b5b86553b377e2d39a683de6285567d5283888e7ef" origin="Generated by Gradle"/> | ||
</artifact> | ||
<artifact name="asm-tree-9.6.pom"> | ||
<sha256 value="1bcb481d7fc16b955bb60ca07c8cfa2424bcee78bdc405bba31c7d6f5dc2d113" origin="Generated by Gradle"/> | ||
</artifact> | ||
</component> | ||
<component group="org.ow2.asm" name="asm-util" version="9.2"> | ||
<artifact name="asm-util-9.2.jar"> | ||
<sha256 value="ff5b3cd331ae8a9a804768280da98f50f424fef23dd3c788bb320e08c94ee598" origin="Generated by Gradle"/> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,9 @@ public class InMemoryTaskQueue<T> implements TaskCollection<T> { | |
private final Set<InMemoryTask<T>> unfinishedOutstandingTasks = new HashSet<>(); | ||
private final AtomicBoolean closed = new AtomicBoolean(false); | ||
|
||
/** Default constructor. */ | ||
public InMemoryTaskQueue() {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is there a need for a default constructor here ? it should be implicit or there're changes related to generics in Java 21 that makes them mandatory ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ahamlat Hi Ameziane, We have javadoc lint enabled in our gradle build and fail our build on lint warnings. One of the "lint" warning that has been enabled since Java 19 is to provide javadoc on default constructors. https://bugs.openjdk.org/browse/JDK-8249634 To avoid adding such empty constructors, we have to disable gradle build failure on javadoc lint warnings. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My opinion would to disable gradle build failure on javadoc lint warnings, and not add "dead code", but this is not blocking. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had a look, looks like we have |
||
|
||
@Override | ||
public synchronized void add(final T taskData) { | ||
assertNotClosed(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the old jacoco entry be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!