Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add network option for LUKSO Mainnet #7223

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

Wolmin
Copy link
Contributor

@Wolmin Wolmin commented Jun 13, 2024

PR description

This PR provides an option to connect to LUKSO Mainnet network, using --network=lukso flag.

Fixed Issue(s)

No matching issues

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Wolmin <lamonos123@gmail.com>
@Hugoo
Copy link

Hugoo commented Jun 17, 2024

For reference, genesis files are available here:

https://github.com/lukso-network/network-configs/blob/main/mainnet/shared/genesis.json

Wolmin and others added 3 commits June 19, 2024 13:32
Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com>
@Wolmin Wolmin marked this pull request as ready for review June 19, 2024 11:39
@fab-10
Copy link
Contributor

fab-10 commented Jun 19, 2024

Could you share a quick guide on how to run a CL/EL to sync and follow the network, for a quick smoke test?

Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing due to a duplicate method name

@Hugoo
Copy link

Hugoo commented Jun 19, 2024

Could you share a quick guide on how to run a CL/EL to sync and follow the network, for a quick smoke test?

hey @fab-10 - maybe this tutorial can help:

https://docs.lukso.tech/networks/mainnet/running-a-node

But the tl:dr is that it is the exact same setup as Ethereum, only the genesis file is different. So any setup you currently use to test Ethereum or Gnosis, will work for LUKSO too.

The genesis files are here:

https://github.com/lukso-network/network-configs/blob/main/mainnet/shared/genesis.json

Signed-off-by: Wolmin <lamonos123@gmail.com>
@Wolmin Wolmin requested a review from fab-10 June 20, 2024 09:46
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggestion to add discovery section to genesis

config/src/main/resources/lukso.json Outdated Show resolved Hide resolved
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just found a couple of things to fix in the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Wolmin and others added 3 commits June 23, 2024 13:05
Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Wolmin <lamonos123@gmail.com>
@Wolmin Wolmin requested a review from fab-10 June 23, 2024 11:17
@fab-10 fab-10 enabled auto-merge (squash) June 24, 2024 08:27
@fab-10
Copy link
Contributor

fab-10 commented Jun 24, 2024

please update again with main branch

@fab-10 fab-10 merged commit a7fd80b into hyperledger:main Jun 24, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants