Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapplying web3 patch for quorum crashes on npm install #12

Closed
jonathan-m-hamilton opened this issue Nov 3, 2019 · 1 comment
Closed

Reapplying web3 patch for quorum crashes on npm install #12

jonathan-m-hamilton opened this issue Nov 3, 2019 · 1 comment
Assignees
@petermetz
Labels
bug Something isn't working

Comments

@jonathan-m-hamilton
Copy link
Contributor

Web3 node module is automatically patched during npm post-install. If web3 was already patched in a previous install the update will crash. temp.

Workaround: Remove the node modules before re-install
@jonathan-m-hamilton jonathan-m-hamilton added the bug Something isn't working label Nov 3, 2019
@petermetz petermetz self-assigned this Nov 18, 2019
@petermetz
Copy link
Member

#50 will give a solution to this as well.

petermetz added a commit that referenced this issue Nov 18, 2019
@petermetz
fix(ci): CI now passes, commented flaky test
47db54b 
Also a list of other changes that were required to make the CI green:
- clean up steps in the script: remove .git folder of websocket package
- install npm dependencies in the fabric and quorum api folders
- update web3 to 1.2.4
- update the post install patching of web3 formatter to match v1.2.4
- clean up: run "down" npm script for fabric and quorum
- force volume re-creation when calling docker-compose up

Also: the CI script is now in a separate .sh file so that it can
be invoked locally on any dev machine that has the dependencies pre-installed

Fixes #12
Fixes #36

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
blefevre pushed a commit to blefevre/blockchain-integration-framework that referenced this issue Feb 4, 2020
@petermetz
fix(ci): CI now passes, commented flaky test
acf35c7 
Also a list of other changes that were required to make the CI green:
- clean up steps in the script: remove .git folder of websocket package
- install npm dependencies in the fabric and quorum api folders
- update web3 to 1.2.4
- update the post install patching of web3 formatter to match v1.2.4
- clean up: run "down" npm script for fabric and quorum
- force volume re-creation when calling docker-compose up

Also: the CI script is now in a separate .sh file so that it can
be invoked locally on any dev machine that has the dependencies pre-installed

Fixes hyperledger#12
Fixes hyperledger#36

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
ryjones pushed a commit that referenced this issue Feb 1, 2023
@VRamakrishna
Merge pull request #12 from VRamakrishna/main
f5278df 
Updated maintainer info and publication references, and renamed folders
ryjones pushed a commit that referenced this issue Feb 1, 2023
@sandeepnRES
Merge pull request #12 from sanvenDev/sanvenDev-patch-1
4fd4463 
Update data-transfer.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petermetz @jonathan-m-hamilton @denis-yu-glotov