Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iroha-connector): make compareAndSetAccountDetail accept correct parameters #1265

Open
hanxu12 opened this issue Aug 21, 2021 · 1 comment
Open

fix(iroha-connector): make compareAndSetAccountDetail accept correct parameters #1265

hanxu12 opened this issue Aug 21, 2021 · 1 comment
Assignees
@travis-payne
Labels
bug Something isn't working dependent Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Iroha Bugs/features related to the Iroha ledger connector plugin P5 Priority 5: Lowest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.

Comments

@hanxu12
Copy link
Contributor

hanxu12 commented Aug 21, 2021 •
edited by petermetz

Depends on #1957

Describe the bug

One argument for compareAndSetAccountDetail, check_empty, is not dealt with inside the plugin-ledger-connector-iroha.ts file. The run-transaction test case also fail to use this argument. Moreover, the old_value argument should be optional, but it is a mandatory argument at this moment.
Please refer to the official Iroha doc for description of compareAndSetAccountDetail.

To Reproduce

Check packages/cactus-plugin-ledger-connector-iroha/src/main/typescript/plugin-ledger-connector-iroha.ts file. Looking for the case of compareAndSetAccountDetail.

Expected behavior

Still runs, but it does not follow behaviors set by the official document.

Logs/Stack traces

N/A

Screenshots

image.png

Cloud provider or hardware configuration:

N/A

Operating system name, version, build:

N/A

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

0.9.0

Hyperledger Cactus Plugins/Connectors Used

Iroha

Additional context
@hanxu12 hanxu12 changed the title fix(iroha-connector): make compareAndSetAccountDetail accept the check_empty argument fix(iroha-connector): make compareAndSetAccountDetail accept the correct parameters Aug 21, 2021
@hanxu12 hanxu12 changed the title fix(iroha-connector): make compareAndSetAccountDetail accept the correct parameters fix(iroha-connector): make compareAndSetAccountDetail accept correct parameters Aug 21, 2021
@petermetz petermetz added Iroha Bugs/features related to the Iroha ledger connector plugin bug Something isn't working Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule. labels Aug 25, 2021
@travis-payne travis-payne self-assigned this Oct 25, 2021
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Oct 27, 2021
feat: adding checkEmpty param to request
03a2f5f 
Current functionality did not make use of the newer additional parameter
in the Iroha command

Closes: hyperledger#1265
Signed-off-by: Travis Payne <travis.payne@accenture.com>
@travis-payne travis-payne mentioned this issue Oct 27, 2021
Closed
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Nov 3, 2021
feat(iroha): adding checkEmpty param to request
f141455 
Current functionality did not make use of the newer additional parameter
in Iroha command

Closes: hyperledger#1265
Signed-off-by: Travis Payne <travis.payne@accenture.com>
petermetz pushed a commit to travis-payne/cactus that referenced this issue Apr 1, 2022
@petermetz
feat(iroha): adding checkEmpty param to request
2a837ea 
Current functionality did not make use of the newer additional parameter
in Iroha command

Closes: hyperledger#1265
Signed-off-by: Travis Payne <travis.payne@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This PR/issue depends on:

@petermetz petermetz added the P5 Priority 5: Lowest label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis-payne travis-payne

Labels
bug Something isn't working dependent Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Iroha Bugs/features related to the Iroha ledger connector plugin P5 Priority 5: Lowest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iroha): adding checkEmpty param to request travis-payne/cactus
3 participants
@petermetz @hanxu12 @travis-payne