Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-tooling): rustc container memory is not defined #2104

Open
petermetz opened this issue Jun 30, 2022 · 0 comments
Open

fix(test-tooling): rustc container memory is not defined #2104

petermetz opened this issue Jun 30, 2022 · 0 comments
Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. help wanted Extra attention is needed P4 Priority 4: Low Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Member

petermetz commented Jun 30, 2022

Describe the bug

   ok 41 All WASM build files OK
    not ok 42 ReferenceError: memory is not defined
      ---
        operator: error
        at: bound (/home/runner/work/cactus/cactus/node_modules/tape-promise/node_modules/onetime/index.js:30:12)
        stack: |-
          /tmp/cactus-test-tooling-rustc-container-test2022530-13267-iz29ib.vbfdl/hello_world_bg.js:165
          cachedInt32Memory0 = new Int32Array(wasm.memory.buffer);
          ReferenceError: memory is not defined
              at Object.<anonymous> (/tmp/cactus-test-tooling-rustc-container-test2022530-13267-iz29ib.vbfdl/hello_world_bg.js:165:42)
              at Generator.next (<anonymous>)
              at Generator.next (<anonymous>)
              at Object.<anonymous> (/tmp/cactus-test-tooling-rustc-container-test2022530-13267-iz29ib.vbfdl/hello_world.js:1)
              at Generator.next (<anonymous>)

To Reproduce

Run packages/cactus-test-tooling/src/test/typescript/integration/rustc-container/rustc-container-target-bundler.test.ts

Expected behavior

Passes.

Cloud provider or hardware configuration:

Everywhere.

Operating system name, version, build:

Ubuntu-20.04

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main

@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers help wanted Extra attention is needed Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-400-expert Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. P4 Priority 4: Low labels Jun 30, 2022
outSH added a commit to outSH/cactus that referenced this issue Jul 4, 2022
- Remove flaky tests from main CI execution.
- Add separate TAP and jest configuration for running only flaky tests.
- Add test:*:flaky scripts in the main package.json
- Add new step to github CI script to run flaky tests as optional
  (i.e. don't fail if flaky test fails)

Closes: hyperledger#2112

Related: hyperledger#2104
Related: hyperledger#1626
Related: hyperledger#2019
Related: hyperledger#1625
Related: hyperledger#1543
Related: hyperledger#1598
Related: hyperledger#1528
Related: hyperledger#1521
Related: hyperledger#1495
Related: hyperledger#1485
Related: hyperledger#1473
Related: hyperledger#1471
Related: hyperledger#1469
Related: hyperledger#1150

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. help wanted Extra attention is needed P4 Priority 4: Low Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Development

No branches or pull requests

1 participant