Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-fabric): add WatchBlocks endpoint #2118

Closed
outSH opened this issue Jul 15, 2022 · 0 comments · Fixed by #2119
Closed

feat(connector-fabric): add WatchBlocks endpoint #2118

outSH opened this issue Jul 15, 2022 · 0 comments · Fixed by #2119
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Jul 15, 2022

  • Add new endpoint for monitoring new blocks.
  • Add FabricApiClient which supports new socketio endpoint.
  • Add functional test to check the new endpoint.
  • Update readme with WatchBlocks usage.

This is part of decommissioning fabric-socketio in order to have single fabric connector.

@outSH outSH added the enhancement New feature or request label Jul 15, 2022
outSH added a commit to outSH/cactus that referenced this issue Jul 15, 2022
- Add new endpoint for monitoring new blocks. Response type is determined from input argument.
  Monitor endpoints are stored in connector.runningWatchBlocksMonitors.
- Add `FabricApiClient` which supports new socketio endpoint.
- Add functional test to check the new endpoint.
- Upgrade fabric-sdk-node to solve test hand issue.
- Loose up `ISocketApiClient` to allow interface monitor options.
- Update readme with WatchBlocks usage.

Regarding fabric-sdk-node upgrade: with sdk2.3, the test used to hang occasionally.
I've ensured that all resources are being cleaned-up, and investigated the problem. The issue was
infinite recurse dns resolution (of fabric peer address) in grpc-js `ResolvingLoadBalancer`.
Could not find exact cause of this strange behaviour, the code there is pretty complex
and didn't want to dig to deep, but I've noticed that recently there were some fixes
in the functions I suspected so I've updated the fabric-sdk, which uses newer grpc-js,
and the problem went away, so I assume this was in fact bug in gprc-js. Run this test on repeat for
hours and didn't notice any error.

Closes: hyperledger#2118

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jul 15, 2022
- Add new endpoint for monitoring new blocks. Response type is determined from input argument.
  Monitor endpoints are stored in connector.runningWatchBlocksMonitors.
- Add `FabricApiClient` which supports new socketio endpoint.
- Add functional test to check the new endpoint.
- Upgrade fabric-sdk-node to solve test hand issue.
- Loose up `ISocketApiClient` to allow interface monitor options.
- Update readme with WatchBlocks usage.

Regarding fabric-sdk-node upgrade: with sdk2.3, the test used to hang occasionally.
I've ensured that all resources are being cleaned-up, and investigated the problem. The issue was
infinite recurse dns resolution (of fabric peer address) in grpc-js `ResolvingLoadBalancer`.
Could not find exact cause of this strange behaviour, the code there is pretty complex
and didn't want to dig to deep, but I've noticed that recently there were some fixes
in the functions I suspected so I've updated the fabric-sdk, which uses newer grpc-js,
and the problem went away, so I assume this was in fact bug in gprc-js. Run this test on repeat for
hours and didn't notice any error.

Closes: hyperledger#2118

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Jul 22, 2022
- Add new endpoint for monitoring new blocks. Response type is determined from input argument.
  Monitor endpoints are stored in connector.runningWatchBlocksMonitors.
- Add `FabricApiClient` which supports new socketio endpoint.
- Add functional test to check the new endpoint.
- Upgrade fabric-sdk-node to solve test hand issue.
- Loose up `ISocketApiClient` to allow interface monitor options.
- Update readme with WatchBlocks usage.

Regarding fabric-sdk-node upgrade: with sdk2.3, the test used to hang occasionally.
I've ensured that all resources are being cleaned-up, and investigated the problem. The issue was
infinite recurse dns resolution (of fabric peer address) in grpc-js `ResolvingLoadBalancer`.
Could not find exact cause of this strange behaviour, the code there is pretty complex
and didn't want to dig to deep, but I've noticed that recently there were some fixes
in the functions I suspected so I've updated the fabric-sdk, which uses newer grpc-js,
and the problem went away, so I assume this was in fact bug in gprc-js. Run this test on repeat for
hours and didn't notice any error.

Closes: hyperledger#2118

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Dec 6, 2022
- Add new endpoint for monitoring new blocks. Response type is determined from input argument.
  Monitor endpoints are stored in connector.runningWatchBlocksMonitors.
- Add `FabricApiClient` which supports new socketio endpoint.
- Add functional test to check the new endpoint.
- Upgrade fabric-sdk-node to solve test hand issue.
- Loose up `ISocketApiClient` to allow interface monitor options.
- Update readme with WatchBlocks usage.

Regarding fabric-sdk-node upgrade: with sdk2.3, the test used to hang occasionally.
I've ensured that all resources are being cleaned-up, and investigated the problem. The issue was
infinite recurse dns resolution (of fabric peer address) in grpc-js `ResolvingLoadBalancer`.
Could not find exact cause of this strange behaviour, the code there is pretty complex
and didn't want to dig to deep, but I've noticed that recently there were some fixes
in the functions I suspected so I've updated the fabric-sdk, which uses newer grpc-js,
and the problem went away, so I assume this was in fact bug in gprc-js. Run this test on repeat for
hours and didn't notice any error.

Closes: hyperledger#2118

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Dec 6, 2022
- Add new endpoint for monitoring new blocks. Response type is determined from input argument.
  Monitor endpoints are stored in connector.runningWatchBlocksMonitors.
- Add `FabricApiClient` which supports new socketio endpoint.
- Add functional test to check the new endpoint.
- Upgrade fabric-sdk-node to solve test hand issue.
- Loose up `ISocketApiClient` to allow interface monitor options.
- Update readme with WatchBlocks usage.

Regarding fabric-sdk-node upgrade: with sdk2.3, the test used to hang occasionally.
I've ensured that all resources are being cleaned-up, and investigated the problem. The issue was
infinite recurse dns resolution (of fabric peer address) in grpc-js `ResolvingLoadBalancer`.
Could not find exact cause of this strange behaviour, the code there is pretty complex
and didn't want to dig to deep, but I've noticed that recently there were some fixes
in the functions I suspected so I've updated the fabric-sdk, which uses newer grpc-js,
and the problem went away, so I assume this was in fact bug in gprc-js. Run this test on repeat for
hours and didn't notice any error.

Closes: hyperledger#2118

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this issue Dec 15, 2022
- Add new endpoint for monitoring new blocks. Response type is determined from input argument.
  Monitor endpoints are stored in connector.runningWatchBlocksMonitors.
- Add `FabricApiClient` which supports new socketio endpoint.
- Add functional test to check the new endpoint.
- Upgrade fabric-sdk-node to solve test hand issue.
- Loose up `ISocketApiClient` to allow interface monitor options.
- Update readme with WatchBlocks usage.

Regarding fabric-sdk-node upgrade: with sdk2.3, the test used to hang occasionally.
I've ensured that all resources are being cleaned-up, and investigated the problem. The issue was
infinite recurse dns resolution (of fabric peer address) in grpc-js `ResolvingLoadBalancer`.
Could not find exact cause of this strange behaviour, the code there is pretty complex
and didn't want to dig to deep, but I've noticed that recently there were some fixes
in the functions I suspected so I've updated the fabric-sdk, which uses newer grpc-js,
and the problem went away, so I assume this was in fact bug in gprc-js. Run this test on repeat for
hours and didn't notice any error.

Closes: hyperledger#2118

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant