Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector-socketio): use common package convention #2216

Closed
outSH opened this issue Nov 23, 2022 · 2 comments · Fixed by #2602
Closed

fix(connector-socketio): use common package convention #2216

outSH opened this issue Nov 23, 2022 · 2 comments · Fixed by #2602
Assignees
@rwat17
Labels
bug Something isn't working

Comments

@outSH
Copy link
Contributor

outSH commented Nov 23, 2022

Describe the bug

All packages should follow the same conventions to avoid problems in the future. Our socketio connector should be fixed to achieve that. Use common package.json and tsconfig.json

@petermetz comments:

I recommend keeping the conventions of the other packages when it comes to declaring the paths & configuring the compiler (tsconfig.json file). That will avoid a big chunk of the issues like when some packages do not get published due to strange bugs: #2069 or other kinds of automation scripts failing if they make assumptions that some of these paths are uniform everywhere. If there is a specific reason for not going uniform with the package configuration properties then that's a different question of course but if it's all the same to you then I'd highly recommend changing it to match the rest of the packages.

... in general every single property in the package.json file that does not have a specific reason (like contributor list or package name/description) to be different should be the same, uniform configuration (same for tsconfig.json files).
@outSH outSH added the bug Something isn't working label Nov 23, 2022
@outSH outSH changed the title fix(connector-socketio): fix(connector-socketio): use common package.js and tsconfig.json Nov 23, 2022
@outSH outSH changed the title fix(connector-socketio): use common package.js and tsconfig.json fix(connector-socketio): use common package convention Nov 23, 2022
@outSH outSH mentioned this issue Nov 23, 2022
Merged
@petermetz petermetz mentioned this issue Jul 24, 2023
Closed
@rwat17
Copy link
Contributor

rwat17 commented Jul 27, 2023

@petermetz Can i take this one?

@petermetz
Copy link
Member

@petermetz Can i take this one?

@rwat17 All yours, thank you very much in advance!

rwat17 added a commit to rwat17/cactus that referenced this issue Aug 9, 2023
@rwat17
fix: use common package convention
c1a42b9 
- change package.json and tsconfig.json files to follow common
convention

Closes: hyperledger#2216
Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
@rwat17 rwat17 mentioned this issue Aug 11, 2023
Merged
rwat17 added a commit to rwat17/cactus that referenced this issue Aug 11, 2023
@rwat17
fix: use common package convention
f15c8d2 
- change package.json and tsconfig.json files to follow common
convention

Closes: hyperledger#2216
Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17 added a commit to rwat17/cactus that referenced this issue Aug 16, 2023
@rwat17
fix: use common package convention
d46e5ea 
- change package.json and tsconfig.json files to follow common
convention

Closes: hyperledger#2216
Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
petermetz pushed a commit to rwat17/cactus that referenced this issue Aug 17, 2023
@rwat17 @petermetz
fix: use common package convention
7590e80 
- change package.json and tsconfig.json files to follow common
convention

Closes: hyperledger#2216
Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
petermetz pushed a commit to rwat17/cactus that referenced this issue Aug 17, 2023
@rwat17 @petermetz
fix: use common package convention
33bf0f0 
- change package.json and tsconfig.json files to follow common
convention

Closes: hyperledger#2216
Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
petermetz pushed a commit to rwat17/cactus that referenced this issue Aug 18, 2023
@rwat17 @petermetz
fix: use common conventions: tsconfig.json, package.json
334a9e6 
- change package.json and tsconfig.json files to follow common
convention

Peter's additions to fix the broken build:
- Included shelljs typings as a dev dependency for the package called
cactus-plugin-ledger-connector-go-ethereum-socketio
- Also included "socket.io-client" as another missing dev dependency for
the package above.

Closes: hyperledger#2216

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Aug 18, 2023
@rwat17 @petermetz
fix: use common conventions: tsconfig.json, package.json
50f5c02 
- change package.json and tsconfig.json files to follow common
convention

Peter's additions to fix the broken build:
- Included shelljs typings as a dev dependency for the package called
cactus-plugin-ledger-connector-go-ethereum-socketio
- Also included "socket.io-client" as another missing dev dependency for
the package above.

Closes: #2216

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@rwat17 @sandeepnRES
fix: use common conventions: tsconfig.json, package.json
2653342 
- change package.json and tsconfig.json files to follow common
convention

Peter's additions to fix the broken build:
- Included shelljs typings as a dev dependency for the package called
cactus-plugin-ledger-connector-go-ethereum-socketio
- Also included "socket.io-client" as another missing dev dependency for
the package above.

Closes: hyperledger#2216

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwat17 rwat17

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use common conventions: tsconfig.json, package.json rwat17/cactus
3 participants
@petermetz @outSH @rwat17