Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(ledger-connector): pilot light performance benchmarks #295

Closed
petermetz opened this issue Sep 25, 2020 · 4 comments · Fixed by #845
Closed

ci(ledger-connector): pilot light performance benchmarks #295

petermetz opened this issue Sep 25, 2020 · 4 comments · Fixed by #845
Assignees
@travis-payne
Labels
good-first-issue Good for newcomers Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.
Milestone
v0.6.0

Comments

@petermetz
Copy link
Member

Description

As a maintainer I want to get an automated warning if a PR passes the tests, but has an adverse impact on performance as measured by a set of baseline benchmarks so that if a PR looks good to me, but in fact reduces performance to a 10th of what it used to be because of some mistake hidden in the code, then I am made aware of this as soon as possible (which hopefully makes it much easier to keep the code performant)

Acceptance Criteria

  1. Performance checks are part of the CI tests and the reports are easily accessible/readable (from the CI logs?)
  2. The performance checks can be executed on the average developer machine and does not require/depend on external infrastructure to be set up (ideally docker should be the only dependency)
@petermetz petermetz added good-first-issue Good for newcomers Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. labels Sep 25, 2020
@petermetz petermetz added this to the v0.7.0 milestone Sep 25, 2020
@petermetz
Copy link
Member Author

FYI: https://www.npmjs.com/package/loadtest

@travis-payne
Copy link

I'll have a look at this

@kikoncuo
Copy link
Contributor

Talk with Hyperledger Caliper
Mark Wagner
Performance and Scale working group

travis-payne pushed a commit to travis-payne/cactus that referenced this issue Apr 23, 2021
feat: incorporating load testing into our CI pipeline
a0c0eca 
This changes utilises Artillery to load test our API endpoint. This is a
first cut implementation.

BREAKING CHANGE: 🧨 Behaviour in a cloud environment is currently untested and could impact
CI pipeline time.

✅ Closes: hyperledger#295

Signed-off-by: Travis Payne <travis.payne@accenture.com>
@travis-payne travis-payne mentioned this issue Apr 23, 2021
Merged
@travis-payne
Copy link

#845

travis-payne pushed a commit to travis-payne/cactus that referenced this issue Apr 26, 2021
refactor: making changes as per PR code review
7a34fe0 
Adding import statements, moving the onFinish() function to a more
logical place.

✅ Closes: hyperledger#295

Signed-off-by: Travis Payne <travis.payne@accenture.com>
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Apr 26, 2021
feat: incorporating load testing into our CI pipeline
7090a2d 
This changes utilizes Artillery to load test our API endpoint. This is a
first cut implementation.

BREAKING CHANGE: 🧨 Behaviors in a cloud environment is currently untested and could impact

✅ Closes: hyperledger#295

Signed-off-by: Travis Payne <travis.payne@accenture.com>
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Apr 26, 2021
feat: incorporating load testing into our CI pipeline
354d10a 
This changes utilises Artillery to load test our API endpoint. This is a
first cut implementation.

BREAKING CHANGE: 🧨 Behaviour in a cloud environment is currently untested and could impact
CI pipeline time.

✅ Closes: hyperledger#295

Signed-off-by: Travis Payne <travis.payne@accenture.com>
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Apr 27, 2021
feat: adding additional info into err logs
afc01c7 
✅ Closes: hyperledger#295

Signed-off-by: Travis Payne <travis.payne@accenture.com>
petermetz pushed a commit that referenced this issue Apr 28, 2021
@petermetz
feat: incorporating load testing into our CI pipeline
7125d10 
This changes utilises Artillery to load test our API endpoint. This is a
first cut implementation.

BREAKING CHANGE: 🧨 Behaviour in a cloud environment is currently untested and could impact
CI pipeline time.

✅ Closes: #295

Signed-off-by: Travis Payne <travis.payne@accenture.com>
petermetz pushed a commit that referenced this issue Apr 28, 2021
@petermetz
feat: adding additional info into err logs
888f85a 
✅ Closes: #295

Signed-off-by: Travis Payne <travis.payne@accenture.com>
@petermetz petermetz modified the milestones: v0.7.0, v0.6.0 Jul 20, 2021
ryjones pushed a commit that referenced this issue Feb 1, 2023
@VRamakrishna
Merge pull request #295 from VRamakrishna/main
c1fa130 
Transaction Listener Support in Fabric Driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis-payne travis-payne

Labels
good-first-issue Good for newcomers Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

feat: incorporating load testing into our CI pipeline travis-payne/cactus
3 participants
@petermetz @kikoncuo @travis-payne