Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-google-sm): create google secret manager plugin #983

Closed
jagpreetsinghsasan opened this issue May 25, 2021 · 0 comments · Fixed by #1017
Closed

feat(keychain-google-sm): create google secret manager plugin #983

jagpreetsinghsasan opened this issue May 25, 2021 · 0 comments · Fixed by #1017
Assignees
@jagpreetsinghsasan
Labels
Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to create a plugin for azure secret manager and perform tasks related to secret management like createSecret and retrieveSecret sort of functionalities.

Acceptance Criteria

  1. New package to be created as @hyperledger/cactus-plugin-keychain-google-sm
  2. Plugin must implement the central keychain plugin Typescript interface we have in the core-api package
  3. The helper class to have methods to expose the credentials, port numbers, etc. that are required to configure/instantiate the PluginKeychainGoogleSm class which is to be implemented as part of the package from point 1)

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy
@petermetz petermetz added the Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. label May 25, 2021
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 10, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
24102f1 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Jun 10, 2021
Merged
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 10, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
acae0de 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 10, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
f18535c 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 11, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
5cf5885 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 11, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
c98d998 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 15, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
9b90ce7 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 28, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
4f2211e 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 6, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
a837782 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-google-sm under packages/
        2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
bbce5d6 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/plugin-keychain-google-sm-mock.ts

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
2a049a4 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan @petermetz
feat(google-sm): added keychain plugin for google secret manager
0b10dae 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
a71a4e0 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
d7e2317 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
fec1e44 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
b24906c 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
6cd9da7 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 26, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
9484917 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 28, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
55d0c5c 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 28, 2021
@jagpreetsinghsasan
feat(google-sm): added keychain plugin for google secret manager
8f397d7 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit that referenced this issue Jul 28, 2021
@jagpreetsinghsasan @petermetz
feat(google-sm): added keychain plugin for google secret manager
1419b2c 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves #983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit to twiggins120/cactus that referenced this issue Aug 5, 2021
@jagpreetsinghsasan @petermetz
feat(google-sm): added keychain plugin for google secret manager
a496bdc 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@jagpreetsinghsasan @RafaelAPB
feat(google-sm): added keychain plugin for google secret manager
ffb19c7 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-google-sm under packages/
	2. Added PluginKeychainGoogleSmMock class to mock the functions of SecretManagerServiceClient under
	packages/cactus-plugin-keychain-google-sm/src/test/typescript/mock/

Resolves hyperledger#983

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(google-sm): added keychain plugin for google secret manager jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan