Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(besu): record locator #1102

Merged
merged 1 commit into from
Jul 22, 2021
Merged

feat(besu): record locator #1102

merged 1 commit into from
Jul 22, 2021

Conversation

AzaharaC
Copy link
Contributor

Resolve #365

@AzaharaC AzaharaC self-assigned this Jun 29, 2021
@AzaharaC AzaharaC changed the title feat(besu): wip record locator feat(besu): record locator Jun 30, 2021
petermetz
petermetz requested changes Jul 1, 2021
View reviewed changes
Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AzaharaC I commented about the ledgerID not being the same as the instance ID, then I thought about how we could go about actually obtaining the ledger ID for the response and came up with this: let's just leave the ledgerID out of the picture for now (and please leave explaining this in a comment on the GH issue as well, referencing this discussion here).

Reason: I'd rather get us going with something simpler first and see how it works out, we can bake in the consortium plugin optional parts later.

packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.json Outdated Show resolved Hide resolved
packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.json Outdated Show resolved Hide resolved
packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.json Outdated Show resolved Hide resolved
packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.json Outdated Show resolved Hide resolved
packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.json Outdated Show resolved Hide resolved
...ages/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts Outdated Show resolved Hide resolved
...ages/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts Outdated Show resolved Hide resolved
...ages/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts Outdated Show resolved Hide resolved
...ages/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts Outdated Show resolved Hide resolved
...pescript/integration/plugin-ledger-connector-besu/deploy-contract/get-record-locator.test.ts Outdated Show resolved Hide resolved
@AzaharaC AzaharaC mentioned this pull request Jul 1, 2021
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021 •
edited
Loading

Codecov Report

Merging #1102 (be32504) into main (bc262a2) will increase coverage by 0.05%.
The diff coverage is 79.74%.

❗ Current head be32504 differs from pull request most recent head e8b08f1. Consider uploading reports for the commit e8b08f1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   73.12%   73.18%   +0.05%     
==========================================
  Files         247      248       +1     
  Lines        8665     8744      +79     
  Branches     1008     1018      +10     
==========================================
+ Hits         6336     6399      +63     
- Misses       1788     1796       +8     
- Partials      541      549       +8
Impacted Files Coverage Δ
...rc/main/typescript/plugin-ledger-connector-besu.ts 77.74% <71.42%> (-0.63%) ⬇️
...pescript/generated/openapi/typescript-axios/api.ts 62.98% <83.33%> (+1.92%) ⬆️
...script/web-services/get-besu-record-endpoint-v1.ts 84.84% <84.84%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc262a2...e8b08f1. Read the comment docs.

@petermetz petermetz mentioned this pull request Jul 1, 2021
Closed
@AzaharaC AzaharaC force-pushed the feat/record-locator branch 2 times, most recently from df7befb to 1a8a106 Compare July 5, 2021 12:10
@AzaharaC AzaharaC marked this pull request as ready for review July 5, 2021 12:11
@AzaharaC AzaharaC requested a review from petermetz July 7, 2021 06:20
@AzaharaC AzaharaC force-pushed the feat/record-locator branch 3 times, most recently from 18f27d9 to 3c3d7a2 Compare July 12, 2021 08:02
@AzaharaC AzaharaC requested a review from petermetz July 16, 2021 11:07
@petermetz petermetz added Besu enhancement New feature or request labels Jul 16, 2021
@petermetz
Copy link
Member

@AzaharaC Let me know if you need help with conflict resolutoin!

@AzaharaC AzaharaC force-pushed the feat/record-locator branch 2 times, most recently from be32504 to e8b08f1 Compare July 22, 2021 11:24
@AzaharaC
feat(besu): record locator
e8b08f1 
Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
@AzaharaC
Copy link
Contributor Author

@AzaharaC Let me know if you need help with conflict resolutoin!

Conflict resolved

@petermetz petermetz merged commit 2410d6d into hyperledger:main Jul 22, 2021
@petermetz petermetz deleted the feat/record-locator branch July 22, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz petermetz approved these changes

@takeutak takeutak takeutak approved these changes

@jonathan-m-hamilton jonathan-m-hamilton Awaiting requested review from jonathan-m-hamilton

@sfuji822 sfuji822 Awaiting requested review from sfuji822

Assignees

@AzaharaC AzaharaC

Labels
Besu enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(besu): define data ledger record locator model type
4 participants
@AzaharaC @codecov-commenter @petermetz @takeutak