remove magic strings #1110
Merged
remove magic strings #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awadhana
force-pushed
the
fix-pki-magic-strings
branch
from
52adeb9
to
5811935
Compare
petermetz
requested changes
Jul 8, 2021
awadhana
force-pushed
the
fix-pki-magic-strings
branch
2 times, most recently
from
9c734a3
to
e79048d
Compare
and linter warnings Fixes hyperledger#1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
awadhana
force-pushed
the
fix-pki-magic-strings
branch
from
c128283
to
9cbccc9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
- Coverage 73.15% 73.13% -0.03%
==========================================
Files 245 245
Lines 8613 8613
Branches 995 995
==========================================
- Hits 6301 6299 -2
- Misses 1781 1783 +2
Partials 531 531
Continue to review full report at Codecov.
|
petermetz
approved these changes
Jul 9, 2021
takeutak
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104
Signed-off-by: Hana Awad awadhana0825@gmail.com