ci: remove nodejs v12 exclusion logic from run custom checks #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takeutak
approved these changes
Apr 13, 2022
petermetz
requested changes
Apr 19, 2022
Leeyoungone
force-pushed
the
ci-1961
branch
2 times, most recently
from
6adb386
to
a5b0e7b
Compare
petermetz
requested changes
May 9, 2022
There was a problem hiding this comment.
@Leeyoungone Could you please also remove the same logic from ./tools/ci.sh ?
# Obtains the major NodeJS version such as "12" from "v12.14.1"
# We only run the custom checks above v12 because the globby dependency's
# latest version is forcing us to use Ecmascript Modules which do not work
# on NodeJS 12 even with the additional flags passed in.
nodejs_version=`node --version | awk -v range=1 '{print substr($0,range+1,2)}'`
if [ "$nodejs_version" -gt "12" ]; then
echo "$(date +%FT%T%z) [CI] NodeJS is newer than v12, running custom checks..."
yarn run custom-checks
fi
petermetz
approved these changes
May 11, 2022
Fixes hyperledger#1961 Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1961
Signed-off-by: Youngone Lee youngone.lee@accenture.com