docs(examples): upgrade Angular to v15 #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
force-pushed
the
petermetz/issue2229
branch
from
078c229
to
7a31735
Compare
petermetz
force-pushed
the
petermetz/issue2229
branch
from
7a31735
to
c023f2f
Compare
|
@petermetz Sorry for our slow review. Now I'm asking Izuru to review this PR. Please wait for a while? |
@takeutak No worries, thank you very much to both you and Izuru! |
VRamakrishna
approved these changes
Jul 13, 2023
1. Upgraded from Angular v14 to v15 for both GUI packages that use it. 2. Upgraded the Typescript compiler project-wide to 4.8.4 3. Due to 2) There was a change needed in the file examples/cactus-example-discounted-asset-trade/transaction-fabric.ts which introduces a constraint on the T type parameter. 4. Disabled the staged files linting because right now ESLint is broken due to our Typescript version being >=4.8.0 (and upgrading it was not an option because then it is broken due to ESM issues...) 5. Cleaned out a lot of the unused dev dependencies of the front-end packages where angular was upgraded. These dependencies were related to end-to-end browser testing which we haven't set up yet to be executed because all the front-end packages are just example code that - while important to test - does not have the highest priority in this sense. 6. Set the rootDir property in the electricity trade example's tsconfig.json file to the standard value (./) because without it the new tsc compiler version seems to be putting the compiled source files in a different location by default (probably an accidental breaking change on the compiler's part or just a lack of my understanding of how the configuration of it should work). With the rootDir explicitly specified, it appears to be compiling the files in the correct location as before. 7. De-duplicated the examples/cactus-example-tcs-huawei/tsconfig.json file's compilerOptions.tsBuildInfoFile property because it was in collision with the electricity trade example's property of the same name, leading to the compiler thinking that it had already compiled the package's code when it has not. Fixes hyperledger#2229 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2229
branch
from
c023f2f
to
11c8b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples/cactus-example-discounted-asset-trade/transaction-fabric.ts
which introduces a constraint on the T type parameter.
due to our Typescript version being >=4.8.0 (and upgrading it was not
an option because then it is broken due to ESM issues...)
packages where angular was upgraded. These dependencies were related to
end-to-end browser testing which we haven't set up yet to be executed
because all the front-end packages are just example code that - while
important to test - does not have the highest priority in this sense.
file to the standard value (./) because without it the new tsc compiler
version seems to be putting the compiled source files in a different
location by default (probably an accidental breaking change on the compiler's
part or just a lack of my understanding of how the configuration of it
should work). With the rootDir explicitly specified, it appears to be
compiling the files in the correct location as before.
Fixes #2229
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com