fix(cmd-api-server): fix CVE-2023-36665 protobufjs try 2 #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Oct 13, 2023
sandeepnRES
approved these changes
Oct 18, 2023
|
@petermetz some conflicts here too, please resolve it in order to merge it. Thanks. |
@sandeepnRES Yes sir! |
1. Upgraded fabric-network from 2.2.10 to 2.2.18 wherever it was still 2.2.10 2. Upgraded ipfs-http-client project-wide from 51.0.1 to 60.0.1 3. Upgraded @google-cloud/secret-manager from 3.9.0 to 5.0.1 This is the second try at fixing this issue. While it was in review other commits already snuck back in more older versions of the vulnerable dependency so before merging this I also add a resolution in the root package.json file to ensure that the vulnerable version is not used at all regardless of it being a dependency of a dependency. [skip ci] Fixes hyperledger#2682 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2682
branch
from
ef49b40
to
19df677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second try at fixing this issue. For some reason the first
PR didn't get it done. The most likely reason is that other commits
in the meantime added back the vulnerable versions of the packages, but
I'm not a 100% sure.
[skip ci]
Fixes #2682
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
[x] Rebased onto
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.[x] Have git sign off at the end of commit message to avoid being marked red. You can add
-sflag when usinggit commitcommand. You may refer to this link for more information.[x] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
[x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[x] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.