Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): added ipv6 default fix #3313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jagpreetsinghsasan
Copy link
Contributor

Comit to be reviewed

docs(faq): added ipv6 default fix

Primary Changes
---------------
1. Added a new FAQ related to configure script stuck at discovering npm registry due to IPv6 defaults

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagpreetsinghsasan LGTM with comments.

FAQ.md Outdated Show resolved Hide resolved
FAQ.md Show resolved Hide resolved
@jagpreetsinghsasan
Copy link
Contributor Author

@petermetz I have updated the faq (yes, indeed the logs were must).

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagpreetsinghsasan Thank you very much for the updates! LGTM

FAQ.md Outdated Show resolved Hide resolved
@petermetz
Copy link
Member

@jagpreetsinghsasan Are you still working on this one?

    Primary Changes
    ---------------
    1. Added a new FAQ related to configure script stuck
       at discovering npm registry due to IPv6 defaults

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan
Copy link
Contributor Author

@outSH requesting for a re-review for the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants