feat(ledger-browser): rewrite fabric application #3320
+5,195
−2,938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dynamic routing based on configuration instead of hardcoded one.
- Add MUI and configure custom theme.
Use this new UI kit to create app better bar and ledger selector.
- Cleanup common application code.
- Add sample SQL data to quickly test the GUI
without running persistence plugins.
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Use react query to fetch data instead of manual fetches. - Remove dead / duplicated code where applicable. - Minor refactors and fixes. Depends on hyperledger#3203 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Refactor ETH app dashboard using MUI components. - Fix ERC20 details page rendering. - Add block and transaction list components that use common `UITableListing`. - Add global notifications that will be displayed in a snackbar. Depends on hyperledger#3207 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- This concludes refactoring of ethereum app, it should be fully usable with mostly same features as before. - Refactor completely ETH app token page into accounts page using MUI components. - Update materialized view in peristence plugin ethereum schema. - Use hyperledger favicon from local files and not from the URL. - Remove files and components that are not used anymore. - Remove unnecessary package dependencies. Depends on hyperledger#3237 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Rewrite fabric app using MUI components and new database schema.
- Improve `UITableListing` to support clickable tables.
- The new app supports the following views:
- Dashboard: Shows summary of blocks and transaction recorded in database.
- Block list: Full list of blocks
- Transaction list: Full list of transactions
- Transaction details: Page that shows full transaction information,
transaction actions (method calls) and endorsements.
Depends on hyperledger#3308
Depends on hyperledger#3279
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
|
This PR/issue depends on: |
petermetz
approved these changes
Jun 13, 2024
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jun 20, 2024
- Remove status apps, its functionality has been moved to the home page. - Add status components for persistence apps. - Add home page that contains cards for each configured app. Clicking on it naviagtes to specific app, clicking on Status button shows status component. - Remove app drawer, replace it with a button that navigates to root path (i.e. the home app, navigation between apps is handled here). - Remove all the remaining dead and legacy code, apply small structure upgrades. - Since this PR removes all old code, and all the current code was written by me and Tomasz, I've also removed previous inactive package contributors. Depends on hyperledger#3320 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UITableListingto support clickable tables.transaction actions (method calls) and endorsements.
Depends on #3308
Depends on #3279
Signed-off-by: Michal Bajer michal.bajer@fujitsu.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.