feat(core-api): decouple web service install & registration #771 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er#771 Primary change: ============== Divide the endpoint installation method into two smaller ones where the first one only instantiates the endpoints and the other one "registers" them as-in it hooks the endpoint up onto the ExpressJS web app object so that it will actually be responded to as HTTP requests come in. Why though? We'll need this for the authorization MVP which will need to be able to introspect the endpoints **prior** to them getting registered so that it can determine authz specific parameters like "is this endpoint secured or non-secure?" or what scopes are necessary for this endpoint? Etc. Additional changes: ================== Everything else that was needed to make the project compile again and the tests passnig (which is a lot because this is a very central, heavily used interface that we just modified). Fixes hyperledger#771 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added
enhancement
kikoncuo
approved these changes
Apr 8, 2021
takeutak
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary change:
Divide the endpoint installation method into two smaller
ones where the first one only instantiates the endpoints
and the other one "registers" them as-in it hooks the
endpoint up onto the ExpressJS web app object so that
it will actually be responded to as HTTP requests come
in.
Why though?
We'll need this for the authorization MVP which will
need to be able to introspect the endpoints prior
to them getting registered so that it can determine
authz specific parameters like "is this endpoint
secured or non-secure?" or what scopes are necessary
for this endpoint? Etc.
Additional changes:
Everything else that was needed to make the project
compile again and the tests passnig (which is a lot
because this is a very central, heavily used
interface that we just modified).
Fixes #771
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com