fix(ci): dependent issues bot workflow has no job id #848 #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check) https://github.com/hyperledger/cactus/actions/runs/772009240/workflow ```yaml jobs: check: runs-on: ubuntu-latest --- ``` You can rename the job in that workflow to Dependabot Issues to match the required status check name: ```yaml jobs: check: runs-on: ubuntu-latest name: Dependabot Issues ---- ``` https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule. Fixes hyperledger#848 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This was referenced Apr 25, 2021
Merged
Merged
takeutak
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a mismatch in what you have set as the name of the required status check for the main branch (Dependabot Issues) and what the check is actually called when the workflow runs (check)
https://github.com/hyperledger/cactus/actions/runs/772009240/workflow
You can rename the job in that workflow to Dependabot Issues to match the required status check name:
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idname
The check will then be displayed as Dependabot Issues - if this was the intended name - and will satisfy the protected branches rule.
Fixes #848
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com