Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-tooling): add OpenEthereumTestLedger #851 #854

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

petermetz
Copy link
Member

We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes #851

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz petermetz added the Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus label Apr 23, 2021
@petermetz petermetz self-assigned this Apr 23, 2021
We did not need to roll our own contanier image for this
so the only thing new here is the class in the test tooling
package that makes it convenient to write test cases against
OpenEthereum. The container image used by the class behind
the scenes is just the stock OpenEthereum image from DockerHub.

Fixes hyperledger#851

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 9ca1f68 into hyperledger:main Apr 29, 2021
@petermetz petermetz deleted the feat-851 branch April 29, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Xdai Tasks/bugs related to the Xdai network and the corresponding ledger connector plugin in Cactus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(test-tooling): add OpenEthereumTestLedger
3 participants