fix(connector-corda): codegen missing prior removal of files #1559
Assignees
Labels
bug
Something isn't working
Corda
dependencies
Pull requests that update a dependency file
P4
Priority 4: Low
Comments
petermetz
added
bug
elenaizaguirre
added a commit
to elenaizaguirre/cactus
that referenced
this issue
Nov 23, 2021
folders in connector-corda. call this new script in generate-server script, before call openapi-generator-cli Closes: hyperledger#1559 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
added a commit
to elenaizaguirre/cactus
that referenced
this issue
Nov 23, 2021
generate-server script calls this new script before call openapi-generator-cli Closes: hyperledger#1559 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
added a commit
to elenaizaguirre/cactus
that referenced
this issue
Nov 26, 2021
added new pattern to 'clean' script to remove autogenerated files from corda main-server Closes: hyperledger#1559 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
added a commit
to elenaizaguirre/cactus
that referenced
this issue
Nov 29, 2021
added new pattern to 'clean' script to remove autogenerated files from corda main-server Closes: hyperledger#1559 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre
added a commit
to elenaizaguirre/cactus
that referenced
this issue
Dec 1, 2021
added new pattern to 'clean' script to remove autogenerated files from corda main-server Closes: hyperledger#1559 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
petermetz
pushed a commit
that referenced
this issue
Dec 1, 2021
added new pattern to 'clean' script to remove autogenerated files from corda main-server Closes: #1559 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Based on this discussion 1 with @elenaizaguirre it seems like the files are not being deleted prior to them being regenerated which most likely lead to the strange situation we've found ourselves where files that are no longer being generated by the generator are still hanging around in/under version control simply because they were never deleted.
To Reproduce
Delete the codegen kotlin code, run a build and observe that there is a git diff which there should be none if this was working fine.
Expected behavior
Deleting generated code and then running the build should always produce equivalent, consistent code.
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
1.0.0-rc.2Hyperledger Cactus Plugins/Connectors Used
Additional context
Came up during: #1294
more specifically
#1294 (comment)
The text was updated successfully, but these errors were encountered: