fix(connector-quorum): web3 Contract type usage #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Apr 17, 2021
Previously you couldn't deploy a contract that had constructor arguments of it's own because there was no way to pass in these. With this improvement this is now possible. Depends on hyperledger#810 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This was referenced Apr 17, 2021
takeutak
approved these changes
Apr 19, 2021
This was broken by an earlier commit: d75b9af Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
fix-quorum-contract-types
branch
from
d7f0097
to
eac0942
Compare
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Apr 19, 2021
Previously you couldn't deploy a contract that had constructor arguments of it's own because there was no way to pass in these. With this improvement this is now possible. Depends on hyperledger#810 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
kikoncuo
approved these changes
Apr 19, 2021
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Apr 19, 2021
Previously you couldn't deploy a contract that had constructor arguments of it's own because there was no way to pass in these. With this improvement this is now possible. Depends on hyperledger#810 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Apr 21, 2021
Previously you couldn't deploy a contract that had constructor arguments of it's own because there was no way to pass in these. With this improvement this is now possible. Depends on hyperledger#810 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this pull request
Apr 21, 2021
Previously you couldn't deploy a contract that had constructor arguments of it's own because there was no way to pass in these. With this improvement this is now possible. Depends on #810 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by an earlier commit:
d75b9af
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com