Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract hard-coded constants to configurable variables #138

Closed
aklenik opened this issue Jul 18, 2018 · 2 comments
Closed

Extract hard-coded constants to configurable variables #138

aklenik opened this issue Jul 18, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@aklenik
Copy link
Contributor

aklenik commented Jul 18, 2018

Currently, some values are hard-coded, e.g., the timeout for chaincode instantiation (#137). A proper configuration support should be added to Caliper.

The two aspects:

  1. The library: I propose nconf, the Fabric SDK uses it, and wrote an elegant wrapper class for it (reusing this wrapper class without introducing the SDK as a constant dependency is another question).
  2. The conventions: I propose a naming convention like in Fabric, since Caliper also has some major submodules. For example, the current OVERWRITE_GOPATH setting could be something like
    CALIPER_FABRIC_OVERWRITEGOPATH

@haojun Opinions?

@haojun
Copy link
Contributor

haojun commented Jul 19, 2018

@panyu4 @jiangyaoguo

@aklenik
Copy link
Contributor Author

aklenik commented Nov 14, 2018

Implemented by PR #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants