Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and potentially remove running caliper unit tests on a merge #1380

Closed
davidkel opened this issue Jun 21, 2022 · 1 comment
Closed
Labels
build enhancement New feature or request

Comments

@davidkel
Copy link
Contributor

davidkel commented Jun 21, 2022

A merge performs a run of the caliper unit tests before performing the publish. I'm not sure why this is done, would be good to find out and document or remove if not necessary to reduce the build pipeline time

@davidkel
Copy link
Contributor Author

davidkel commented Aug 5, 2022

From Attila: Probably it was due to a reasoning like "they're cheap and couldn't hurt" :D although pr unit tests aren't run again automatically when a separate pr is merged (thus the upstream changes), so the test after merge ensures that the published codebase still works as intended I guess

I think this gives to good reasons to keep the unit tests on PR merge, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants