Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSI-32: Compiled code must not be in source repos #336

Merged
merged 1 commit into from
Oct 15, 2021
Merged

LSI-32: Compiled code must not be in source repos #336

merged 1 commit into from
Oct 15, 2021

Conversation

ryjones
Copy link
Member

@ryjones ryjones commented Sep 30, 2021

Signed-off-by: Ry Jones ry@linux.com

Signed-off-by: Ry Jones <ry@linux.com>
@ryjones ryjones requested a review from a team as a code owner September 30, 2021 16:29
@yeasy
Copy link
Member

yeasy commented Oct 1, 2021

Any location to store these tools?
We can download them at runtime.

@yeasy
Copy link
Member

yeasy commented Oct 9, 2021

@XuHugo suggest create a base image to include all needed tools.

@ryjones
Copy link
Member Author

ryjones commented Oct 9, 2021

Lots of projects use Artifactory: https://hyperledger.jfrog.io/ui/repos/tree/General/

Let me know if you want to set it up

@yeasy

@yeasy
Copy link
Member

yeasy commented Oct 11, 2021

These binaries can be downloaded from https://hyperledger.jfrog.io/artifactory/fabric-binaries/hyperledger-fabric-linux-amd64-2.2-stable.tar.gz. We should add the command in building api-engine and other images (who use the binaries).

@ryjones
Copy link
Member Author

ryjones commented Oct 12, 2021

thank you. Please merge this change so I can close the licensing issue.

@zhuyuanmao
Copy link
Member

zhuyuanmao commented Oct 12, 2021

These binaries can be downloaded from https://hyperledger.jfrog.io/artifactory/fabric-binaries/hyperledger-fabric-linux-amd64-2.2-stable.tar.gz. We should add the command in building api-engine and other images (who use the binaries).

I have created a pr for this one. #337

@yeasy yeasy merged commit 06248c2 into hyperledger:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants