Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voulume mapping #430

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Conversation

zhuyuanmao
Copy link
Member

Mapping the whole folder instead of single files.

Signed-off-by: Yuanmao Zhu yuanmao@ualberta.ca

Mapping the whole folder instead of single files.

Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao zhuyuanmao requested a review from a team as a code owner March 29, 2022 00:14
@@ -43,7 +43,8 @@ def create_node():
port_map = ast.literal_eval(request.form.get("port_map"))
volumes = [
'/var/run/:/host/var/run/',
'/opt/fabric/{}/msp:/etc/hyperledger/fabric/msp'.format(node_name),
'/opt/fabric/{}:/etc/hyperledger/fabric'.format(node_name),
Copy link
Member

@yeasy yeasy Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest put two local paths into the same dir, e..g,

/opt/hyperledger/fabric/{}:/etc/hyperledger/fabric
/opt/hyperledger/production/{}:/var/hyperledger/production

Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@yeasy yeasy merged commit 30f8be9 into hyperledger:main Apr 4, 2022
@zhuyuanmao zhuyuanmao deleted the fix-volume-mapping branch May 24, 2022 03:11
@zhuyuanmao zhuyuanmao restored the fix-volume-mapping branch May 24, 2022 03:11
@zhuyuanmao zhuyuanmao deleted the fix-volume-mapping branch May 24, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants