Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CE-715]Fixed the fabric operator image path issue #45

Merged
merged 1 commit into from
Oct 23, 2019
Merged

[CE-715]Fixed the fabric operator image path issue #45

merged 1 commit into from
Oct 23, 2019

Conversation

litong01
Copy link
Contributor

@litong01 litong01 commented Oct 23, 2019

[CE-715]Since the fabric operator image is now officially
being placed on docker hub, we need to change the
operator deployment script to reflect that change
and modify the README.md accordingly. This patch
fixes these issues.

Copy link
Contributor

@hightall hightall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there related Jira or issue? I suggest we use the issue instead of Jira.

@litong01
Copy link
Contributor Author

Is there related Jira or issue? I suggest we use the issue instead of Jira.

Haitai, my understanding is that we should continue use jira for issue tracking. I would like to just use github issues for that though.

@litong01
Copy link
Contributor Author

Is there related Jira or issue? I suggest we use the issue instead of Jira.

confirmed with brent (earlier with Ry), we will be continuing using jira for issue tracking. So please do not create issues on this repo.

@litong01 litong01 changed the title Fixed the fabric operator image path issue [CE-715]Fixed the fabric operator image path issue Oct 23, 2019
@hightall
Copy link
Contributor

@litong01 I think we need to discuss it at this weekly meeting, I can not find any benefits of using jira after migrate to GitHub to manage code. Issue is native support of GitHub, and can connect PR with it, why to use jira?

@litong01
Copy link
Contributor Author

I have also placed the jira issue reference in the title of the pull request.

@hightall
Copy link
Contributor

I have also placed the jira issue reference in the title of the pull request.

you haven't update title of the commit message. For quick solution, please update the title of your commit message, and this PR can be merged, and we need discuss the tracking system this Friday. I can't understand why still use jira.

@litong01
Copy link
Contributor Author

@hightall the title has been changed.

@hightall
Copy link
Contributor

@hightall the title has been changed.

截屏2019-10-23下午9 51 43

this shown only one commit, and the commit message not include the jira number.

Since the fabric operator image is now officially
being placed on docker hub, we need to change the
operator deployment script to reflect that change
and modify the README.md accordingly. This patch
fixes these issues.

Signed-off-by: Tong Li <litong01@us.ibm.com>
@litong01 litong01 merged commit 3961a1f into hyperledger:master Oct 23, 2019
@litong01 litong01 deleted the Fix-operator-image-path branch October 23, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants