Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#issue-487]Modify the request to create a node #488

Merged
merged 7 commits into from
Sep 16, 2022
Merged

[#issue-487]Modify the request to create a node #488

merged 7 commits into from
Sep 16, 2022

Conversation

fengyangsy
Copy link
Contributor

  1. Change the quantity parameter to a number
  2. The action parameter is passed through the message body

Signed-off-by: fengyang_sy fengyang.09186@h3c.com

Close #487

@fengyangsy
[#issue-487]Modify the request to create a node
e0846a2 
1. Change the quantity parameter to a number
2. The action parameter is passed through the message body

Signed-off-by: fengyang_sy <fengyang.09186@h3c.com>
@fengyangsy fengyangsy requested a review from a team as a code owner September 15, 2022 11:00
fengyangsy
fengyangsy commented Sep 16, 2022
View reviewed changes
Copy link
Contributor Author

@fengyangsy fengyangsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The parseInt function adds parameters
  2. using backticks

fengyangsy
fengyangsy commented Sep 16, 2022
View reviewed changes
Copy link
Contributor Author

@fengyangsy fengyangsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the request information of create node

@zhuyuanmao zhuyuanmao merged commit 3f6ede4 into hyperledger:main Sep 16, 2022
zhuyuanmao pushed a commit to zhuyuanmao/cello that referenced this pull request Sep 23, 2022
@fengyangsy @zhuyuanmao
[#issue-487]Modify the request to create a node (hyperledger#488)
6296650 
* [#issue-487]Modify the request to create a node
1. Change the quantity parameter to a number
2. The action parameter is passed through the message body

Signed-off-by: fengyang_sy <fengyang.09186@h3c.com>

* Update node.js

* Update index.js

* Update index.js

* Update node.js

* Update index.js

* Update index.js

Signed-off-by: fengyang_sy <fengyang.09186@h3c.com>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
zhuyuanmao pushed a commit to zhuyuanmao/cello that referenced this pull request Sep 23, 2022
@fengyangsy @zhuyuanmao
[#issue-487]Modify the request to create a node (hyperledger#488)
bc83edc 
* [#issue-487]Modify the request to create a node
1. Change the quantity parameter to a number
2. The action parameter is passed through the message body

Signed-off-by: fengyang_sy <fengyang.09186@h3c.com>

* Update node.js

* Update index.js

* Update index.js

* Update node.js

* Update index.js

* Update index.js

Signed-off-by: fengyang_sy <fengyang.09186@h3c.com>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@fengyangsy fengyangsy deleted the issue-#487 branch October 13, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuyuanmao zhuyuanmao zhuyuanmao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify the request to create a node
2 participants
@fengyangsy @zhuyuanmao