Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo readme file and makefile #519

Merged
merged 21 commits into from
Mar 14, 2023
Merged

Update repo readme file and makefile #519

merged 21 commits into from
Mar 14, 2023

Conversation

zhuyuanmao
Copy link
Member

@zhuyuanmao zhuyuanmao commented Feb 17, 2023 •
edited
Loading

  • Remove unused makefile rules
  • Fix make doc rule
  • Fix make setup-worker and make setup-master
  • Update readme

Screenshot 2023-02-18 at 5 05 03 PM

@zhuyuanmao
Update makefile rules
0f47595 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Update readme
4404f8f 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Add CI badge
1070f12 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Update readme
5fb1c64 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao zhuyuanmao requested a review from a team as a code owner February 17, 2023 04:07
@zhuyuanmao
remove start-dashboard rule
e22b60e 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Fix CI since missing make rules
6717c47 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
yeasy
yeasy reviewed Feb 18, 2023
View reviewed changes
Makefile.old Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@zhuyuanmao
Fix makefile
e0f5775 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Fix info messages
6fe5b28 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Fix docker-compose
767d9e8 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Fix comment
d2d8e7f 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Update readme
283fd03 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
yeasy
yeasy reviewed Feb 24, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@zhuyuanmao
Order makefile rules and create a build_images shell script
9f0487a 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Update readme
04c0027 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
Update readme format
9840149 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
fix format
90dc0c5 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
reorder makefile rules
e8859b1 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
fix format
fc25de3 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
fix format
b2b911a 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
fix format
63a53c4 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao
update node version
1a60f81 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao zhuyuanmao requested a review from yeasy March 6, 2023 01:01
@zhuyuanmao
Address feedback
89e2bb5 
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
@zhuyuanmao zhuyuanmao requested a review from yeasy March 11, 2023 21:19
yeasy
yeasy requested changes Mar 14, 2023
View reviewed changes
Copy link
Member

@yeasy yeasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need these images in fact.

@yeasy yeasy merged commit 29fc9a3 into hyperledger:main Mar 14, 2023
@xichen1 xichen1 mentioned this pull request Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeasy yeasy yeasy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhuyuanmao @yeasy