Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Resolves #80, Bumped fabric-proto-go to fabric-protos-go-apiv2 #84

Closed

Commits on Sep 17, 2023

  1. Resolves hyperledger#80, this commit contains dependency update from …

    …fabric-protos-go to fabric-protos-go-apiv2 and "github.com/golang/protobuf"(deprecated) to "google.golang.org/protobuf
    
    Bumped google.golang.org/protobuf to v1.31.0 from v1.5.2
    
    It can be noticed that the package "github.com/golang/protobuf" is still an indirect dependency used by google.golang.org/grpc/credentials v1.53.0, even the latest update v1.58.0 still does.
    
    Made sure all tests passed.
    
    CHANGES INCLUDE:
    
    	SOURCE CODE
    The "AssertProtoEqual" was borrowed from: // https://github.com/hyperledger/fabric-gateway/blob/cd1bc1f3fcf007bd97244120d9a8d112153322cd/pkg/internal/test/transaction.go#L20-L22
    which is more apt to test the Protobufs of google.golang.org/protobuf/ implementation. It replaced assertEqual.
    
    now := ptypes.TimestampNow() --> now := timestamp.Now()
    
    IMPORTS
    All Import aliases are kept.
    "github.com/golang/protobuf/proto" --> "google.golang.org/protobuf/proto"
    
    pb "github.com/hyperledger/fabric-protos-go/peer" --> pb "github.com/hyperledger/fabric-protos-go-apiv2/peer"
    
    "github.com/golang/protobuf/ptypes/timestamp" --> timestamp "google.golang.org/protobuf/types/known/timestamppb"
    
    "github.com/hyperledger/fabric-protos-go/ledger/queryresult" --> "github.com/hyperledger/fabric-protos-go-apiv2/ledger/queryresult"
    
    "github.com/hyperledger/fabric-protos-go/ledger/msp" →
    "github.com/hyperledger/fabric-protos-go-apiv2/ledger/msp"
    "github.com/hyperledger/fabric-protos-go/common" --> "github.com/hyperledger/fabric-protos-go-apiv2/common"
    
    Signed-off-by: tobigiwa <giwaoluwatobi@gmail.com>
    tobigiwa committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    48328d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Draft: This is a working change on bumping the fabric-chaincode-go to…

    … use fabric-protos-go-apiv2 and the new protobufs lib. This commits includes changes to fuction signatures, return values, interface definition and type definition to type "ChaincodeMessage" and "pb.Response"
    
    . It is a breaking change.
    Signed-off-by: tobigiwa <giwaoluwatobi@gmail.com>
    tobigiwa committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a12d7c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Merge branch 'main' into tobytobias-update-proto-dependency

    Signed-off-by: tobigiwa <giwaoluwatobi@gmail.com>
    tobigiwa committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8045ec0 View commit details
    Browse the repository at this point in the history