Add OpenTelemetry #153
Add OpenTelemetry #153
Conversation
atoulme
force-pushed
the
add_opentelemetry
branch
8 times, most recently
from
24e8bac
to
2b4001f
Compare
|
Hi @atoulme, thanks very much for your pull request. Adding metrics to Fabric looks like it could be really useful and I think it would be good to get this proposal reviewed by the wider Fabric community. There's a Request For Comments process which would need to be followed before merging any PRs, however it would probably be a good idea discussing on Rocket Chat and on one of the maintainer calls beforehand. For example to discuss the choice of OpenTelemetry/B3 headers over alternatives etc. From an implementation point of view, I noticed that the protobuf code had been updated, but that wasn't reflected in a change to the protos project, or the peer code. Thanks again, and I look forward to hearing from you about taking this proposal forward. James |
|
Thanks James, I look forward to working with you on this! |
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
atoulme
force-pushed
the
add_opentelemetry
branch
from
3c23e23
to
0ca507f
Compare
|
The RFC is open here for further discussion: hyperledger/fabric-rfcs#42 |
|
@atoulme I'm hoping that your RFC will get a mention at the next maintainers call to get some more visibility |
|
That'd be swell. I've been busy elsewhere, but I can try to join the call to explain what this is all about. |
|
Sounds good- I think these are the meeting details if you are able to join |
|
Closing the PR, note because this is a bad idea, but really needs the RFC as discussed above. |
Signed-off-by: Antoine Toulme antoine@lunar-ocean.com
This adds OpenTelemetry to Fabric Java chaincode.