Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java releases #313

Merged
merged 1 commit into from Nov 12, 2021
Merged

Fix Java releases #313

merged 1 commit into from Nov 12, 2021

Conversation

jt-nti
Copy link
Member

@jt-nti jt-nti commented Nov 11, 2021

Needing to know which versions of javadoc support the --no-module-directories option is error prone and also causes confusion running builds locally

The pom.xml has been update with a javadoc-no-module-directories profile which automatically adds the option for newer JDKs

Also removes the pluginManagement section, since there are no child builds, and strictly enfoces a 1.8 JDK for release builds

Signed-off-by: James Taylor jamest@uk.ibm.com

Needing to know which versions of javadoc support the --no-module-directories option is error prone and also causes confusion running builds locally

The pom.xml has been update with a javadoc-no-module-directories profile which automatically adds the option for newer JDKs

Also removes the pluginManagement section, since there are no child builds, and strictly enfoces a 1.8 JDK for release builds

Signed-off-by: James Taylor <jamest@uk.ibm.com>
@jt-nti jt-nti changed the title [WIP] Fix Java releases Fix Java releases Nov 12, 2021
@jt-nti jt-nti marked this pull request as ready for review November 12, 2021 10:22
@bestbeforetoday bestbeforetoday merged commit 6807455 into hyperledger:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants