Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interface instead of @grpc/grpc-js Client class in public API #555

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Use interface instead of @grpc/grpc-js Client class in public API #555

merged 1 commit into from
Feb 10, 2023

Commits on Feb 10, 2023

  1. Use interface instead of @grpc/grpc-js Client class in public API 

    Since the gRPC Client is a concrete class, changes to private members can cause version-to-version type incompatibilities if the caller has a dependency on a different version of @grpc/grpc-js. Requiring an interface containing only public methods of the gRPC Client class avoids these issues, provided there are no breaking changes in the gRPC Client API.

Signed-off-by: Mark S. Lewis <mark_lewis@uk.ibm.com>
    @bestbeforetoday
    bestbeforetoday committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    cbba090 View commit details
    Browse the repository at this point in the history