Add missing license identifier #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes hyperledger#72 and adds missing license headers. It also adds Fabric's license check to the make checks target. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
g2flyer
approved these changes
May 15, 2019
|
|
||
| license: | ||
| @echo "License: Running licence checks.." | ||
| @sh ${GOPATH}/src/github.com/hyperledger/fabric/scripts/check_license.sh |
There was a problem hiding this comment.
Calling it via ${TOP}/../../hyperledger/fabric/scripts/check_license.sh seem a bit more robust (i.e., it will also work when you have multiple GOPATH components)? But i have no strong opinion on this ...
|
Yes, I guess there are also some missing Intel copyrights already; can you do a pass and add a commit here or reuse mine and also sign-off?! Let's not over complicate it. @bvavala Can you do this? |
|
Nice check. |
4 tasks
bvavala
added a commit
to bvavala/fabric-private-chaincode
that referenced
this pull request
May 17, 2019
Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
mbrandenburger
pushed a commit
that referenced
this pull request
May 24, 2019
* check ercc container and force remove * force remove in ecc_enclave * ecc check container and image for stop/delete * tlcc_enclave force rm files * typo in tlcc mrenclave generate script * fix sh complaint * check container in ecc make docker * fixes PR #73 * remove makefile variable; better error message Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #72 and adds missing license headers.
It also adds Fabric's license check to the
make checks target.
Signed-off-by: Marcus Brandenburger bur@zurich.ibm.com