-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish compiled output using v2 Go protobuf API #76
Comments
I agree publishing to a new |
jt-nti
added a commit
to jt-nti/fabric-protos
that referenced
this issue
May 27, 2022
Generate Go bindings using the new build process for the v2 Go protobuf API Contributes to issue hyperledger#76 Signed-off-by: James Taylor <jamest@uk.ibm.com>
jt-nti
added a commit
to jt-nti/fabric-protos
that referenced
this issue
May 27, 2022
Generate Go bindings using the new build process for the v2 Go protobuf API Contributes to issue hyperledger#76 Signed-off-by: James Taylor <jamest@uk.ibm.com>
jt-nti
added a commit
to jt-nti/fabric-protos
that referenced
this issue
Jun 6, 2022
Generate Go bindings using the new build process for the v2 Go protobuf API Contributes to issue hyperledger#76 Signed-off-by: James Taylor <jamest@uk.ibm.com>
jt-nti
added a commit
to jt-nti/fabric-protos
that referenced
this issue
Jun 7, 2022
Generate Go bindings using the new build process for the v2 Go protobuf API Contributes to issue hyperledger#76 Signed-off-by: James Taylor <jamest@uk.ibm.com>
jt-nti
added a commit
to jt-nti/fabric-protos
that referenced
this issue
Jun 9, 2022
Generate Go bindings using the new build process for the v2 Go protobuf API Contributes to issue hyperledger#76 Signed-off-by: James Taylor <jamest@uk.ibm.com>
andrew-coleman
pushed a commit
that referenced
this issue
Jun 9, 2022
Generate Go bindings using the new build process for the v2 Go protobuf API Contributes to issue #76 Signed-off-by: James Taylor <jamest@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a Fabric application developer
I want fabric-protos-go to include stubs compiled for the v2 Go API for protocol buffers
So that we can take advantage of new features in v2 protobuf API within our consuming application
See https://go.dev/blog/protobuf-apiv2 for details.
This could be achieved by continuing to publish the protobufs compiled using the v1 Go API for protocol buffers at the top level of the fabric-protos-go repository, and publishing the equivalent stubs using the v2 API in a
v2
sub-directory within that repository, as per the Go module publishing guidance. This would allow consumers to migrate to the newer protobuf APIs while maintaining complete compatibility for existing consumers.An alternative (and perhaps better) approach would be to publish to a different publishing reposity, such as
hyperledger/fabric-protos-go-apiv2
. This would avoid any confusion about the module versioning. This wouldn't really be a v2 of the fabric-protos-go module, just an alternative implementation backed by the v2 Go API for protocol buffers.The text was updated successfully, but these errors were encountered: