New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc for TWGC admin sdk repo transform #55
Conversation
Signed-off-by: Sam Yuan <yy19902439@126.com>
@denyeart , @bestbeforetoday , @davidkhala , @xiaohui249 , @channingduan , @Peng-Du, @jkneubuh |
I fully support this initiative to develop a programmatic API that can replace the varying admin capabilities in legacy SDKs, and provide a programmatic alternative to existing CLI commands. This would provide a good foundation on which to base CLI commands that are decoupled from the core Fabric implementation - in other words to replace the peer CLI commands - although actually delivering those CLI commands doesn't necessarily need to be within the scope of this RFC. There is a lot of value in providing an admin API that can be used by a Kubernetes operator; particularly a Golang API. I think it is important that dependencies are kept relatively minimal, and certainly must not include core Fabric. For Fabric protobuf bindings, the ones documented here should be fine to use, and are probably better than generating new bindings. Just for reference, there is at least a partial CLI implementation in the fabric-cli repository which it might be possible to rebase on this new admin API rather than the legacy fabric-sdk-go. |
Signed-off-by: Mark S. Lewis <mark_lewis@uk.ibm.com>
Refine admin SDK RFC text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely support this RFC- the described admin SDK would provide a really solid foundation for a new Fabric CLI, CI/CD tools e.g. GitHub actions, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent start; a dedicated admin library is long overdue for Fabric.
I'm looking at it for being able to support the Ansible Scripts (https://ibm-blockchain.github.io/ansible-collection/modules.html) not all the required function is there yet, but this will give a great starting point.
I've sent a mailing list notification that this RFC is in Final Comment Period. We intend to merge the RFC and open a github repository within a week. |
No unresolved comments... I'll go ahead and merge and open the fabric respository. |
Hi team,
Hope by this RFC, we can one step further for decouple peer cli works.
Signed-off-by: Sam Yuan yy19902439@126.com