Add account-based token sample (go chaincode) #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhil550
reviewed
Sep 4, 2020
sijocherian
suggested changes
Sep 14, 2020
lehors
reviewed
Sep 30, 2020
|
Thanks folks. I'll make the updates here. And I will also add the remaining ERC20 functions to make it functionally identical with the Javascript PR: #327 |
sijocherian
reviewed
Oct 2, 2020
There was a problem hiding this comment.
ERC20 interface signature sounds better for adoption.
We may want to be conscious of the Terminology we use in the sample: like AccountID, ClientID , Owner , User, Recipient
ERC20 uses the terminology "balance of an account with address _owner"
https://eips.ethereum.org/EIPS/eip-20
Account & Balance seem like the most compatible ones. I am on the fence about "address"
Add an account-based token sample go chaincode, as well as an associated readme tutorial. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an account-based token sample go chaincode, as well as an associated readme tutorial.
Signed-off-by: David Enyeart enyeart@us.ibm.com