-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
private-data go chaincode now sets the Asset owner as client identity certificate string #374
private-data go chaincode now sets the Asset owner as client identity certificate string #374
Conversation
…string (instead of base64 str) go chaincode now sets the Asset owner as client identity certificate string (instead of base64 str) Reason for the update: "GetClientIdentity().GetID()" api in go chaincode returns base64 string, while same api in java chaincode returns the same data as string go & java chaincode sets same owner string updated js app verify method Signed-off-by: Sijo Cherian <sijo@ibm.com>
d22ec02
to
cba6d85
Compare
[Using Private Data tutorial](https://hyperledger-fabric.readthedocs.io/en/latest/private_data_tutorial.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no diff here
This a good update, and I will use it for the auction samples. However, there are some updates to the tutorial that need to be made. Now that all the tutorials use these samples, we may need to put in more effort to keep the branches and samples tags in sync:
The
The result will show the name and issuer of the owner certificate:
|
@nikhil550 I will send a PR soon to update private-data tutorial in fab repo. Is there any other changes your are suggesting? This is just a tutorial change in steps for validating Asset Owner visually. |
No other changes, just making a note. |
go chaincode now sets the Asset owner as client identity certificate string (instead of base64 str) ref hyperledger/fabric-samples#374 better PDC description Signed-off-by: Sijo Cherian <sijo@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll merge this and the doc PR and Fabric repo.
go chaincode now sets the Asset owner as client identity certificate string (instead of base64 str) ref hyperledger/fabric-samples#374 better PDC description Signed-off-by: Sijo Cherian <sijo@ibm.com>
go chaincode now sets the Asset owner as client identity certificate string (instead of base64 str) ref hyperledger/fabric-samples#374 better PDC description Signed-off-by: Sijo Cherian <sijo@ibm.com> (cherry picked from commit 3406c35)
go chaincode now sets the Asset owner as client identity certificate string (instead of base64 str) ref hyperledger/fabric-samples#374 better PDC description Signed-off-by: Sijo Cherian <sijo@ibm.com> (cherry picked from commit 3406c35)
go chaincode now sets the Asset owner as client identity certificate string (instead of base64 str) ref hyperledger/fabric-samples#374 better PDC description Signed-off-by: Sijo Cherian <sijo@ibm.com> (cherry picked from commit 3406c35)
go chaincode now sets the Asset owner as client identity certificate string (instead of base64 str) ref hyperledger/fabric-samples#374 better PDC description Signed-off-by: Sijo Cherian <sijo@ibm.com> (cherry picked from commit 3406c35)
x509::CN=${Org1UserId},OU=client+OU=org1+OU=department1::CN=ca.org1.example.com,O=org1.example.com,L=Durham,ST=North Carolina,C=US