Completely Remove Short Name Support

[jcastrence]

Type of change

• Improvement (improvement to code, performance, etc)

Description

• Short names are a crutch that can prevent someone from learning how to deploy their own chaincode. Short names have been replaced with their full path name. Short names are no longer recognized by shell scripts.

[nikhil550]

I was playing around with the error text,a nd I realized that the defaults are still set in the main network.sh script:

# chaincode name defaults to "basic"
CC_NAME="basic"
# chaincode path defaults to "NA"
CC_SRC_PATH="NA"
# use go as the default language for chaincode
CC_SRC_LANGUAGE="go"

I would remove those from that script, and then set the defaults to "NA" in the first lines of the deployCC script. You can then set the following if statements accordingly

[jcastrence]

@nikhil550 I noticed that when I was playing with the script but couldn't figure out why it was still setting them to the defaults. Thanks for pointing that out.

[nikhil550]

I was playing around with the error text,a nd I realized that the defaults are still set in the main network.sh script:

# chaincode name defaults to "basic"
CC_NAME="basic"
# chaincode path defaults to "NA"
CC_SRC_PATH="NA"
# use go as the default language for chaincode
CC_SRC_LANGUAGE="go"

I would remove those from that script, and then set the defaults to "NA" in the first lines of the deployCC script. You can then set the following if statements accordingly

Actually, playing around, removing them is the wrong thing to do. If you remove the defaults, then the variables do not exist. Rather, set them to NA in the network.sh script instead.

[jcastrence]

I was playing around with the error text,a nd I realized that the defaults are still set in the main network.sh script:

# chaincode name defaults to "basic"
CC_NAME="basic"
# chaincode path defaults to "NA"
CC_SRC_PATH="NA"
# use go as the default language for chaincode
CC_SRC_LANGUAGE="go"

I would remove those from that script, and then set the defaults to "NA" in the first lines of the deployCC script. You can then set the following if statements accordingly

Actually, playing around, removing them is the wrong thing to do. If you remove the defaults, then the variables do not exist. Rather, set them to NA in the network.sh script instead.

Would we still need to check if the variables are empty then in the deployCC script, since our variables will now always be set to NA by default?

[nikhil550]

I was playing around with the error text,a nd I realized that the defaults are still set in the main network.sh script:

# chaincode name defaults to "basic"
CC_NAME="basic"
# chaincode path defaults to "NA"
CC_SRC_PATH="NA"
# use go as the default language for chaincode
CC_SRC_LANGUAGE="go"

I would remove those from that script, and then set the defaults to "NA" in the first lines of the deployCC script. You can then set the following if statements accordingly

Actually, playing around, removing them is the wrong thing to do. If you remove the defaults, then the variables do not exist. Rather, set them to NA in the network.sh script instead.

Would we still need to check if the variables are empty then in the deployCC script, since our variables will now always be set to NA by default?

You can check for "NA". see comment above.

[denyeart]

I grepped fabric-samples and fabric for occurrences of "deployCC". I see a few more occurrences where not all three flags are provided (ccn, ccp, ccl).

[nikhil550]

You can probably remove the valid call example from this message. (If you keep it, add the text Valid call example:

[nikhil550]

Looks good, just a couple nits.

You will need to update the help text to state that go is no longer he default chaincode language:

-ccl <language> - Programming language of the chaincode to deploy: go (default), java, javascript, typescript

[nikhil550]

LGTM. I will leave open in case anyone else has any comments

[SamYuan1990]

Hi guys,

Please correct me for any mis understanding.
In this pr, we are removed short names and replaced by full name. as

Short names are a crutch that can prevent someone from learning how to deploy their own chaincode. Short names have been replaced with their full path name. Short names are no longer recognized by shell scripts.

but ... why removed the default values?
is the default values prevent someone from learning or the short name prevents?