[FABN-1609] close client in gateway disconnect #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, although the channels are being closed, this will catch any of the loose orderers and peers that are created and connected due to connection profile loading which are not assigned to channels. |
|
@harrisob Thanks bret, would you mind elaborate more about where else imported connection profile will affect? |
add close function to fabric-common/client add client.close to gateway.disconnect basic unit test Signed-off-by: davidliu <david-khala@hotmail.com>
harrisob
approved these changes
Jul 27, 2020
harrisob
pushed a commit
to harrisob/fabric-sdk-node
that referenced
this pull request
Aug 14, 2020
add close function to fabric-common/client add client.close to gateway.disconnect basic unit test Signed-off-by: davidliu <david-khala@hotmail.com>
This was referenced Sep 16, 2021
This was referenced Apr 12, 2022
bestbeforetoday
added a commit
to bestbeforetoday/fabric-sdk-node
that referenced
this pull request
Mar 8, 2023
Release includes: - Add support for getting CA server information (hyperledger#510) - Close Client in Gateway disconnect (hyperledger#287) - Include timestamp in transaction events (hyperledger#490) Signed-off-by: Mark S. Lewis <mark_lewis@uk.ibm.com>
Merged
bestbeforetoday
added a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add close function to fabric-common/client
add client.close to gateway.disconnect
basic unit test
Signed-off-by: davidliu david-khala@hotmail.com