Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry to Fabric node SDK #425

Closed
wants to merge 1 commit into from

Conversation

atoulme
Copy link

@atoulme atoulme commented Feb 11, 2021

Fixes #503

It introduces OpenTelemetry instrumentation of gRPC messages through tracing.

Signed-off-by: Antoine Toulme antoine@lunar-ocean.com

Base automatically changed from master to main March 22, 2021 13:01
@atoulme atoulme marked this pull request as ready for review September 17, 2021 16:52
@atoulme atoulme requested a review from a team as a code owner September 17, 2021 16:52
…exchanges

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
@bestbeforetoday
Copy link
Member

/ci-run

@bestbeforetoday
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bestbeforetoday
Copy link
Member

The PR build is failing:

node_modules/@opentelemetry/core/build/src/baggage/utils.d.ts(1,25): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/baggage/utils.d.ts(7,22): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/common/attributes.d.ts(1,52): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/common/global-error-handler.d.ts(1,27): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/common/time.d.ts(1,22): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/common/types.d.ts(1,27): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/propagation/composite.d.ts(1,74): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/HttpTraceContextPropagator.d.ts(1,87): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/TraceState.d.ts(1,22): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/rpc-metadata.d.ts(1,31): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/sampler/AlwaysOffSampler.d.ts(1,41): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/sampler/AlwaysOnSampler.d.ts(1,41): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/sampler/ParentBasedSampler.d.ts(1,82): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/sampler/TraceIdRatioBasedSampler.d.ts(1,41): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/trace/suppress-tracing.d.ts(1,25): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/core/build/src/utils/environment.d.ts(1,30): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/instrumentation-grpc/build/src/instrumentation.d.ts(3,22): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/instrumentation/build/src/instrumentation.d.ts(1,52): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/instrumentation/build/src/types.d.ts(1,32): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/instrumentation/build/src/types_internal.d.ts(1,32): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/node/build/src/NodeTracerProvider.d.ts(1,35): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/BasicTracerProvider.d.ts(1,51): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/Span.d.ts(1,22): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/Span.d.ts(7,45): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/SpanProcessor.d.ts(1,25): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/TimedEvent.d.ts(1,40): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/Tracer.d.ts(1,22): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/export/NoopSpanProcessor.d.ts(1,25): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/export/ReadableSpan.d.ts(1,81): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/types.d.ts(1,44): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
node_modules/@opentelemetry/tracing/build/src/types.d.ts(3,32): error TS2307: Cannot find module '@opentelemetry/api' or its corresponding type declarations.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! fabric-sdk-node@2.3.0-snapshot compile: tsc --project fabric-network/tsconfig.json

@bestbeforetoday
Copy link
Member

Closing as this has been stale for months. Please reopen if you have updates that fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for OpenTelemetry tracing
2 participants