Skip to content

Commit

Permalink
Merge "[FAB-3242] Remove CouchDB skip TODO"
Browse files Browse the repository at this point in the history
  • Loading branch information
binhn authored and Gerrit Code Review committed Apr 25, 2017
2 parents 8d7595d + 0f828ef commit cd3def8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Expand Up @@ -39,7 +39,7 @@ var lastKeyIndicator = byte(0x01)

var binaryWrapper = "valueBytes"

//TODO querySkip is implemented for future use by query paging
//querySkip is implemented for future use by query paging
//currently defaulted to 0 and is not used
var querySkip = 0

Expand Down
5 changes: 2 additions & 3 deletions core/ledger/util/couchdb/couchdb.go
Expand Up @@ -770,9 +770,8 @@ func (dbclient *CouchDatabase) ReadDoc(id string) (*CouchDoc, string, error) {

//ReadDocRange method provides function to a range of documents based on the start and end keys
//startKey and endKey can also be empty strings. If startKey and endKey are empty, all documents are returned
//TODO This function provides a limit option to specify the max number of entries. This will
//need to be added to configuration options. Skip will not be used by Fabric since a consistent
//result set is required
//This function provides a limit option to specify the max number of entries and is supplied by config.
//Skip is reserved for possible future future use.
func (dbclient *CouchDatabase) ReadDocRange(startKey, endKey string, limit, skip int) (*[]QueryResult, error) {

logger.Debugf("Entering ReadDocRange() startKey=%s, endKey=%s", startKey, endKey)
Expand Down

0 comments on commit cd3def8

Please sign in to comment.