[FAB-18398] Added osnadmin binary to tools image #2275
Conversation
managing channels without system channel is the main feature of 2.3, however the osnadmin binary was left out from the 2.3 tools docker image. This PR will fix that issue and also need to be back ported to 2.3.0 tools image. Signed-off-by: Tong Li <litong01@us.ibm.com>
There was a problem hiding this comment.
On the fabric side of things, we've been trying to move away from encouraging the use of a fabric-tools container in favor of installing and running the binaries natively. You'll note most (if not all) of the tutorials no longer reference a fabric-tools CLI container, though it is used in a few scripts to avoid a manual install of the jq dependency for brand-new users.
All that being said, it wasn't necessarily an oversight that the osnadmin binary wasn't included in the image, it just wasn't clear that there was community want/need for its inclusion.
|
@Mergifyio backport release-2.3 |
managing channels without system channel is the main feature of 2.3, however the osnadmin binary was left out from the 2.3 tools docker image. This PR will fix that issue and also need to be back ported to 2.3.0 tools image. Signed-off-by: Tong Li <litong01@us.ibm.com> (cherry picked from commit 00e644d) # Conflicts: # images/tools/Dockerfile
|
Command
|
|
@Mergifyio backport release-2.3 |
|
Command
|
|
@Mergifyio backport release-2.3 |
|
Command
|
managing channels without system channel is the main feature of 2.3, however the osnadmin binary was left out from the 2.3 tools docker image. This PR will fix that issue and also need to be back ported to 2.3.0 tools image. Signed-off-by: Tong Li <litong01@us.ibm.com>
managing channels without system channel is the main feature of 2.3, however the osnadmin binary was left out from the 2.3 tools docker image. This PR will fix that issue and also need to be back ported to 2.3.0 tools image. Signed-off-by: Tong Li <litong01@us.ibm.com>
managing channels without system channel is the
main feature of 2.3, however the osnadmin binary
was left out from the 2.3 tools docker image.
This PR will fix that issue and also need to be
back ported to 2.3.0 tools image.
Signed-off-by: Tong Li litong01@us.ibm.com
Type of change
Description
Additional details
Related issues