New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabric v3: Remove legacy chaincode (LSCC) support #3983
Comments
Hi @denyeart, I would like to contribute on this. Could you please guide me? |
@Sayalikukkar This will be a complex epic as the v1.x chaincode lifecycle is embedded in many places. The first thing to do would be to decompose the work into smaller issues under this epic. @ale-linux led the work to add dual support in Fabric v2.x, so probably best to get his high level thoughts first. |
Hi @denyeart, I would like to take the lead on this if you are fine. Several things have to be done to get it complete:
I can prepare a more detailed plan on how to do it in small portions. |
Thanks @C0rWin , that would be great! Perhaps @Sayalikukkar could help on some of the tasks. I mentioned @ale-linux because I remember there was some prior design thought around removing the old lifecycle... I've found the presentation where @ale-linux wrote this down in 2019:
|
Hello @C0rWin, Let me know if anything is required from my end. |
Thanks for the suggestion, I will prepare a work plan and then we can decide on how to approach it. |
This is a fair plan, though, I think once we will remove all external dependencies which are still using legacy LSCC, we won't have any aggregator and will be able to proceed with the removal. Currently, the legacy is exposed via peer cli, SDKs, and inside the integration tests. Therefore, IMO we just need to start by simply removing code using legacy APIs. |
This commit takes care to remove DeployChaincodeLegacy function from the integration tests suite to address hyperledger#3983 as part of removing legacy chaicnode lifecycle. Due to size of the changes the work gonna be split into several PRs, this is the first one in the row. Signed-off-by: Artem Barger <artem@bargr.net>
This commit removes the DeployChaincodeLegacy function from the integration tests suite to address hyperledger#3983 as part of eliminating the legacy chaincode lifecycle. Due to the changes in size, the work will be split into several PRs. This is the first one in a row. Signed-off-by: Artem Barger <artem@bargr.net>
This commit removes the DeployChaincodeLegacy function from the integration tests suite to address hyperledger#3983 as part of eliminating the legacy chaincode lifecycle. Due to the changes in size, the work will be split into several PRs. This is the first one in a row. Signed-off-by: Artem Barger <artem@bargr.net>
This commit removes the DeployChaincodeLegacy function from the integration tests suite to address #3983 as part of eliminating the legacy chaincode lifecycle. Due to the changes in size, the work will be split into several PRs. This is the first one in a row. Signed-off-by: Artem Barger <artem@bargr.net>
Fabric v2.x supports both the v1.x chaincode lifecycle and the v2.x chaincode lifecycle. The proposal here is to remove support for the v1.x chaincode lifecycle for Fabric v3.x.
There are many places in the code that have dual support for v1.x and v2.x chaincode lifecycle. Each of those locations will need to be assessed to remove the v1.x chaincode lifecycle support, and then the v1.x chaincode lifecycle itself will need to be removed.
The text was updated successfully, but these errors were encountered: