Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCS11 in Fabric 2.2.x doesn't support MSPs with CA certificates that included RSA public keys #4127

Closed
marianothiago opened this issue Mar 30, 2023 · 4 comments

Comments

@marianothiago
Copy link

marianothiago commented Mar 30, 2023

When starting the peer on fabric 2.2.9 with HSM (PKCS11), the following error message is being displayed:

"Certificate's public key type not recognized. Supported keys: [ECDSA]

To fix this bug, a pull request was requested

#4128

@marianothiago marianothiago changed the title PKCS11 from Fabric 2.2.x don't support MSPs with CA certificates that included RSA public keys PKCS11 in Fabric 2.2.x doesn't support MSPs with CA certificates that included RSA public keys Mar 31, 2023
@denyeart
Copy link
Contributor

denyeart commented Apr 3, 2023

Some history (also posted to the PR):

RSA removal commit - 80a20e3
Discussion about RSA removal and decision to restore - #2069
Restore RSA for SW implementation - #2121

It looks like it was only restored for SW implementation, so it makes sense to restore for PKCS11 implementation as well.

@denyeart
Copy link
Contributor

@marianothiago Thanks for fixing in release-2.2. Have you checked whether updates are needed in main and release-2.5? It looks like the code structure is different in those branches.

Depending on your answer, we could close this issue as complete or suggest updates in main and release-2.5. Note that most production users will be updating from v2.2.x to v2.5.x since it is the latest LTS release.

@marianothiago
Copy link
Author

@denyeart Thanks for help. I ran several tests on version 2.5.0, including organizations that have MSP certificates using RSA in their chain, and it worked great, as expected.

@denyeart
Copy link
Contributor

ok, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants